-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: rs-editor: manage multiple units #6671
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6671 +/- ##
============================================
+ Coverage 28.26% 28.28% +0.01%
Complexity 2179 2179
============================================
Files 1051 1052 +1
Lines 130335 130736 +401
Branches 2578 2602 +24
============================================
+ Hits 36839 36976 +137
- Misses 92007 92247 +240
- Partials 1489 1513 +24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
69fa619
to
12744d4
Compare
12744d4
to
fdb4922
Compare
696f001
to
04b8ef8
Compare
front/src/modules/rollingStock/components/RollingStockEditor/RollingStockEditorFormHelpers.tsx
Outdated
Show resolved
Hide resolved
Some bugs :
|
04b8ef8
to
22b4544
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a6967db
to
9963e39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work :) left some comments
front/src/modules/rollingStock/components/RollingStockCard/RollingStockCardDetail.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/rollingStock/components/RollingStockEditor/formatSpreadSheetCurve.ts
Outdated
Show resolved
Hide resolved
front/src/modules/rollingStock/components/RollingStockEditor/RollingStockEditorFormHelpers.tsx
Show resolved
Hide resolved
front/src/modules/rollingStock/components/RollingStockEditor/RollingStockEditorForm.tsx
Outdated
Show resolved
Hide resolved
aee261d
to
8e50afd
Compare
front/src/modules/rollingStock/components/RollingStockEditor/RollingStockEditorFormHelpers.tsx
Show resolved
Hide resolved
front/src/modules/stdcmAllowances/components/StdcmAllowances.tsx
Outdated
Show resolved
Hide resolved
front/src/modules/trainschedule/components/ManageTrainSchedule/Allowances/AllowancesActions.tsx
Outdated
Show resolved
Hide resolved
...dules/trainschedule/components/ManageTrainSchedule/Allowances/AllowancesStandardSettings.tsx
Outdated
Show resolved
Hide resolved
8230803
to
1f2aa16
Compare
70e08fe
to
3d0c424
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM and tested
3d0c424
to
db03948
Compare
db03948
to
4baace9
Compare
Fixes https://github.com/osrd-project/osrd-confidential/issues/183