-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: add datadog and opentelemetry #6677
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6677 +/- ##
============================================
- Coverage 28.29% 28.26% -0.03%
Complexity 2179 2179
============================================
Files 1052 1053 +1
Lines 130736 130813 +77
Branches 2602 2602
============================================
- Hits 36987 36979 -8
- Misses 92236 92321 +85
Partials 1513 1513
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6eff2bb
to
2e8bbe2
Compare
2e8bbe2
to
075c791
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few request changes but it looks good to me.
I failed to see the tracks editoast in jaegger however.
It may be due to misuse on my part.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nevermind it's working 🎉 We should enable open telemetry by default using docker.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not tested. thanks! 🚀
I also defaulted to activate Opentelemetry by default (like in |
00cdd7c
to
3b9367c
Compare
3b9367c
to
821fe41
Compare
Following up on #6649 and #6650,
editoast
now can report all traces events to Opentelemetry or Datadog depending on runtime configuration.Ready for review since I was able to observe traces on local for Opentelemetry (launching a local Jaeger to consume it) and Datadog (launching a local Datadog agent and looking at the logs).
Screenshot of existing traces on Jaeger
Logs from a Datadog agent
Look at the
traces received
in the following log.Closes #6660.