Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix user setting dropdown hidden #6678

Merged
merged 1 commit into from
Feb 23, 2024
Merged

Conversation

Uriel-Sautron
Copy link
Contributor

close #6651

@Uriel-Sautron Uriel-Sautron requested a review from a team as a code owner February 20, 2024 15:12
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 27.89%. Comparing base (ac93bc8) to head (f2d2b1a).
Report is 3 commits behind head on dev.

Files Patch % Lines
front/src/common/BootstrapSNCF/DropdownSNCF.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6678      +/-   ##
============================================
- Coverage     27.90%   27.89%   -0.01%     
  Complexity     2172     2172              
============================================
  Files          1041     1041              
  Lines        128667   128674       +7     
  Branches       2567     2567              
============================================
- Hits          35904    35895       -9     
- Misses        91280    91296      +16     
  Partials       1483     1483              
Flag Coverage Δ
core 79.36% <ø> (ø)
editoast 75.20% <ø> (-0.04%) ⬇️
front 8.41% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sim51
Copy link
Contributor

sim51 commented Feb 21, 2024

LGTM !

@flomonster flomonster self-requested a review February 21, 2024 13:16
@nicolaswurtz nicolaswurtz added this pull request to the merge queue Feb 23, 2024
@SharglutDev SharglutDev removed this pull request from the merge queue due to a manual request Feb 23, 2024
- add z-index property in .dropdown.thether-element
@SharglutDev SharglutDev added this pull request to the merge queue Feb 23, 2024
Merged via the queue into dev with commit 689d6c3 Feb 23, 2024
22 checks passed
@SharglutDev SharglutDev deleted the usn/fix-user-setting branch February 23, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User settings window is hidden because it appear underneath other components
5 participants