Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: tests: get pathfinding by trigram search #6684

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

Yohh
Copy link
Contributor

@Yohh Yohh commented Feb 20, 2024

  • add data-testid to TypeAndPath elements needed
  • create a new scenario for each 005 e2e-test to keep parallelism
  • add search by trigram replacing search by clicking on map

close #6683

@Yohh Yohh requested a review from a team as a code owner February 20, 2024 15:53
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (461fc91) 27.74% compared to head (480037e) 27.73%.

Files Patch % Lines
front/src/common/Pathfinding/TypeAndPath.tsx 0.00% 4 Missing ⚠️
front/src/common/Pathfinding/Pathfinding.tsx 0.00% 1 Missing ⚠️
...onents/ManageTrainSchedule/Itinerary/Itinerary.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6684      +/-   ##
============================================
- Coverage     27.74%   27.73%   -0.01%     
  Complexity     2172     2172              
============================================
  Files          1042     1042              
  Lines        128465   128470       +5     
  Branches       2569     2569              
============================================
- Hits          35638    35633       -5     
- Misses        91342    91352      +10     
  Partials       1485     1485              
Flag Coverage Δ
core 79.36% <ø> (ø)
editoast 75.19% <ø> (-0.03%) ⬇️
front 8.34% <0.00%> (-0.01%) ⬇️
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

- add data-testid to TypeAndPath elements needed
- create a new scenario for each 005 e2e-test to keep parallelism
- add search by trigram replacing search by clicking on map
@Yohh Yohh force-pushed the yoh/front-tests-get-pathfinding-by-trigram-search branch from cac9ef7 to 480037e Compare February 20, 2024 16:21
@nicolaswurtz nicolaswurtz added this pull request to the merge queue Feb 20, 2024
Merged via the queue into dev with commit f7339f1 Feb 20, 2024
22 checks passed
@nicolaswurtz nicolaswurtz deleted the yoh/front-tests-get-pathfinding-by-trigram-search branch February 20, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: tests: get pathfinding by trigram search
2 participants