Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix infra error message for invalid value #6698

Merged
merged 1 commit into from
Feb 21, 2024
Merged

front: fix infra error message for invalid value #6698

merged 1 commit into from
Feb 21, 2024

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Feb 21, 2024

fix #6507

@sim51 sim51 requested a review from a team as a code owner February 21, 2024 11:40
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (906da79) 27.79% compared to head (4105e74) 27.79%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6698      +/-   ##
============================================
- Coverage     27.79%   27.79%   -0.01%     
  Complexity     2172     2172              
============================================
  Files          1043     1043              
  Lines        128732   128732              
  Branches       2570     2570              
============================================
- Hits          35777    35775       -2     
- Misses        91469    91471       +2     
  Partials       1486     1486              
Flag Coverage Δ
core 79.36% <ø> (ø)
editoast 75.32% <ø> (-0.01%) ⬇️
front 8.34% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.25% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sim51 sim51 changed the title front: fix infra error message for invalid invalid value front: fix infra error message for invalid value Feb 21, 2024
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, LGTM

@sim51 sim51 enabled auto-merge February 21, 2024 13:22
@sim51 sim51 added this pull request to the merge queue Feb 21, 2024
Merged via the queue into dev with commit fe945c3 Feb 21, 2024
22 checks passed
@sim51 sim51 deleted the bsi/issue-6507 branch February 21, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

format for the intervals are incorrect
3 participants