Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure tracing to output on stderr for editoast #6699

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

leovalais
Copy link
Contributor

Currently tracing writes on stdout but it's problematic when we output some result on stdout as well.
I encountered the problem for the openapi generation cargo run openapi > openapi.yaml.

@leovalais leovalais requested a review from a team as a code owner February 21, 2024 13:00
@leovalais leovalais added kind:bug Something isn't working area:editoast Work on Editoast Service labels Feb 21, 2024
@leovalais leovalais requested a review from woshilapin February 21, 2024 13:00
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (825ec5d) 27.90% compared to head (b87132f) 27.90%.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6699      +/-   ##
============================================
- Coverage     27.90%   27.90%   -0.01%     
  Complexity     2172     2172              
============================================
  Files          1041     1041              
  Lines        128660   128660              
  Branches       2567     2567              
============================================
- Hits          35905    35904       -1     
- Misses        91272    91273       +1     
  Partials       1483     1483              
Flag Coverage Δ
core 79.36% <ø> (ø)
editoast 75.24% <ø> (-0.01%) ⬇️
front 8.41% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 81.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch

@leovalais leovalais force-pushed the lva/tracing-on-stderr branch from d3c77fa to 878f0f8 Compare February 22, 2024 10:08
@leovalais leovalais force-pushed the lva/tracing-on-stderr branch from f4412fb to 878f0f8 Compare February 22, 2024 11:12
@leovalais leovalais force-pushed the lva/tracing-on-stderr branch from 878f0f8 to b87132f Compare February 22, 2024 13:46
@leovalais leovalais requested a review from flomonster February 22, 2024 14:11
@leovalais leovalais added this pull request to the merge queue Feb 23, 2024
Merged via the queue into dev with commit 9441df3 Feb 23, 2024
22 checks passed
@leovalais leovalais deleted the lva/tracing-on-stderr branch February 23, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants