front: fix none display when no study type in operational studies

[RomainValls]

closes #6655

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 28.65%. Comparing base (cbe74a9) to head (7fad5bf).

Files	Patch %	Lines
...ront/src/applications/operationalStudies/consts.ts	0.00%	13 Missing ⚠️
...c/modules/study/components/AddOrEditStudyModal.tsx	0.00%	10 Missing ⚠️
front/src/modules/study/utils.ts	0.00%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev    #6746      +/-   ##
============================================
- Coverage     28.65%   28.65%   -0.01%     
  Complexity     2235     2235              
============================================
  Files          1063     1063              
  Lines        131643   131643              
  Branches       2647     2647              
============================================
- Hits          37723    37722       -1     
- Misses        92399    92400       +1     
  Partials       1521     1521              

Flag	Coverage Δ
core	79.78% <ø> (ø)
editoast	74.90% <ø> (-0.01%)	⬇️
front	8.92% <0.00%> (ø)
gateway	2.49% <ø> (ø)
railjson_generator	87.26% <ø> (ø)
tests	83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Akctarus]

Tested, LGTM :)

[SharglutDev]

You don't need to change anything in AddOrEditStudyModal.tsx. To solve the issue, you can just hide the study_type div if study_type === 'nothingSelected' in StudyCard.tsx and Study.tsx

Edit : as discussed with @RomainValls and @clarani, we are going to handle the issue by putting an empty string for the "none" study_type and see with the back-end if they can avoid letting the front send undefined or null for the study_type.

[SharglutDev]

Thank you for the changes, everything works great. Just one last comment for me.

[SharglutDev]

Lgtm, good job !

To go further, I think we could, in another PR, do the same logic for the study_states by putting them in an array with as const and maybe we could reuse the createSelectOptions function for both states and types.

What do you think @clarani ?

[clarani]

✅ LGTM, only a small comment :)

[clarani]

Yes agree with @SharglutDev for studyStates, we should create an issue for that 🙏