Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pathfinding endpoint for train schedule V2 #6753

Merged
merged 2 commits into from
Mar 6, 2024
Merged

Add pathfinding endpoint for train schedule V2 #6753

merged 2 commits into from
Mar 6, 2024

Conversation

younesschrifi
Copy link
Contributor

@younesschrifi younesschrifi commented Feb 27, 2024 •
edited by flomonster
Loading

close #6740

@codecov Codecov
Copy link

codecov bot commented Feb 27, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 18.30065% with 250 lines in your changes are missing coverage. Please review.

Project coverage is 28.26%. Comparing base (e25652d) to head (a76e77a).
Report is 4 commits behind head on dev.

Files Patch % Lines
editoast/src/views/v2/pathfinding.rs 5.02% 208 Missing ⚠️
editoast/src/modelsv2/infra_objects.rs 0.00% 22 Missing ⚠️
editoast/src/redis_utils.rs 75.60% 10 Missing ⚠️
editoast/src/schema/operational_point.rs 0.00% 10 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #6753      +/-   ##
============================================
- Coverage     28.27%   28.26%   -0.02%     
- Complexity     2177     2179       +2     
============================================
  Files          1048     1049       +1     
  Lines        129976   130290     +314     
  Branches       2577     2578       +1     
============================================
+ Hits          36756    36820      +64     
- Misses        91731    91981     +250     
  Partials       1489     1489
Flag Coverage Δ
core 79.44% <ø> (+0.04%) ⬆️
editoast 75.14% <18.30%> (-0.75%) ⬇️
front 8.62% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster force-pushed the yci/create-model-v2-timetable branch 2 times, most recently from f0b60b9 to 0cad0d3 Compare February 27, 2024 15:21
@younesschrifi younesschrifi force-pushed the yci/pathfinding-v2-endpoint branch from e9dcb31 to 61b02e4 Compare February 27, 2024 15:38
Base automatically changed from yci/create-model-v2-timetable to dev February 27, 2024 17:38
@younesschrifi younesschrifi force-pushed the yci/pathfinding-v2-endpoint branch 2 times, most recently from d6163b5 to 9073b8c Compare February 27, 2024 21:12
@younesschrifi younesschrifi changed the base branch from dev to fam/editoast-map-code-refactoring February 27, 2024 21:15
@younesschrifi younesschrifi force-pushed the yci/pathfinding-v2-endpoint branch from 9073b8c to 871550e Compare February 27, 2024 21:16
Base automatically changed from fam/editoast-map-code-refactoring to dev February 28, 2024 09:40
@younesschrifi younesschrifi force-pushed the yci/pathfinding-v2-endpoint branch from c63e745 to cb1189f Compare March 1, 2024 08:58
@flomonster flomonster changed the title editoast: new pathfinding endpoint Add pathfinding endpoint for train schedule V2 Mar 1, 2024
@younesschrifi younesschrifi force-pushed the yci/pathfinding-v2-endpoint branch from cb1189f to 08b964d Compare March 1, 2024 10:34
flomonster
flomonster reviewed Mar 1, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall it looks good. We should add some documentation on all pathfinding.rs functions.

flomonster
flomonster reviewed Mar 1, 2024
View reviewed changes
@flomonster flomonster force-pushed the yci/pathfinding-v2-endpoint branch 3 times, most recently from 5f4401d to a621683 Compare March 1, 2024 19:06
@younesschrifi younesschrifi force-pushed the yci/pathfinding-v2-endpoint branch 3 times, most recently from 0614e02 to 0385953 Compare March 1, 2024 19:40
@flomonster flomonster marked this pull request as ready for review March 4, 2024 09:24
@flomonster flomonster requested a review from a team as a code owner March 4, 2024 09:24
@flomonster flomonster requested review from Wadjetz and leovalais March 4, 2024 09:39
leovalais
leovalais requested changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly lgtm, a few changes and cosmetic remarks:

@younesschrifi younesschrifi force-pushed the yci/pathfinding-v2-endpoint branch from 936833e to 0af75fa Compare March 5, 2024 09:18
@younesschrifi younesschrifi requested a review from leovalais March 5, 2024 09:19
@younesschrifi younesschrifi force-pushed the yci/pathfinding-v2-endpoint branch from 0af75fa to 4859f1d Compare March 5, 2024 10:22
@flomonster @younesschrifi
editoast: fix train schedule schema
b4d5fcf 
- Replace NonBlankString to Identifier
- Fix Identifier implementation of ToSchema
@younesschrifi younesschrifi force-pushed the yci/pathfinding-v2-endpoint branch from 4859f1d to 7d5fdf1 Compare March 5, 2024 13:35
@younesschrifi @flomonster
editoast: new pathfinding endpoint
a76e77a 
Co-authored-by: Florian Amsallem <[email protected]>
@younesschrifi younesschrifi force-pushed the yci/pathfinding-v2-endpoint branch from 7d5fdf1 to a76e77a Compare March 6, 2024 09:07
leovalais
leovalais approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@younesschrifi younesschrifi added this pull request to the merge queue Mar 6, 2024
Merged via the queue into dev with commit b1f8892 Mar 6, 2024
22 checks passed
@younesschrifi younesschrifi deleted the yci/pathfinding-v2-endpoint branch March 6, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster left review comments

@Wadjetz Wadjetz Wadjetz approved these changes

@leovalais leovalais leovalais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS2: Add editoast pathfinding endpoint
4 participants
@younesschrifi @Wadjetz @flomonster @leovalais