Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix no data display when no train in timetable in op studies #6765

Conversation

RomainValls
Copy link
Contributor

closes #5468

@RomainValls RomainValls self-assigned this Feb 28, 2024
@RomainValls RomainValls requested a review from a team as a code owner February 28, 2024 13:54
Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 28.35%. Comparing base (829deba) to head (f7fe5d6).
Report is 1 commits behind head on dev.

Files Patch % Lines
...ons/operationalStudies/views/SimulationResults.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6765      +/-   ##
============================================
- Coverage     28.35%   28.35%   -0.01%     
  Complexity     2177     2177              
============================================
  Files          1047     1047              
  Lines        129455   129453       -2     
  Branches       2576     2576              
============================================
- Hits          36707    36703       -4     
- Misses        91260    91262       +2     
  Partials       1488     1488              
Flag Coverage Δ
core 79.39% <ø> (ø)
editoast 75.93% <ø> (-0.02%) ⬇️
front 8.61% <0.00%> (+<0.01%) ⬆️
gateway 2.50% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RomainValls RomainValls force-pushed the rvs/front-fix-no-data-display-when-no-train-in-timetable-in-opstudies branch from 76cd9ec to f7fe5d6 Compare February 28, 2024 14:38
Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Math-R Math-R added this pull request to the merge queue Feb 29, 2024
Merged via the queue into dev with commit 6fc8499 Feb 29, 2024
22 checks passed
@Math-R Math-R deleted the rvs/front-fix-no-data-display-when-no-train-in-timetable-in-opstudies branch February 29, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: change "no train schedule" message in scenario page
3 participants