Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cartographic tile cache expiration time #6781

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Mar 1, 2024

When a tile was queried and the cache was hit, the tile's expiry time was not reset.

@flomonster flomonster requested a review from a team as a code owner March 1, 2024 19:22
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 28.27%. Comparing base (4f7b93f) to head (5fbdaac).

Files Patch % Lines
editoast/src/views/layers/mod.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6781      +/-   ##
============================================
- Coverage     28.27%   28.27%   -0.01%     
  Complexity     2177     2177              
============================================
  Files          1048     1048              
  Lines        129976   129978       +2     
  Branches       2577     2577              
============================================
- Hits          36754    36748       -6     
- Misses        91733    91741       +8     
  Partials       1489     1489              
Flag Coverage Δ
core 79.39% <ø> (ø)
editoast 75.85% <0.00%> (-0.04%) ⬇️
front 8.62% <ø> (ø)
gateway 2.50% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster enabled auto-merge March 4, 2024 09:43
@flomonster flomonster added this pull request to the merge queue Mar 4, 2024
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and easy to review!

Merged via the queue into dev with commit 76276a6 Mar 4, 2024
22 checks passed
@flomonster flomonster deleted the fam/fix-expiry-map-tiles branch March 4, 2024 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants