Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: move LightRollingStock to ModelV2 #6821

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Mar 7, 2024

closes #6319

@hamz2a hamz2a requested a review from a team as a code owner March 7, 2024 16:13
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 62.90323% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 28.69%. Comparing base (d8e883a) to head (43a5aa0).
Report is 4 commits behind head on dev.

Files Patch % Lines
editoast/src/modelsv2/light_rolling_stock.rs 62.85% 13 Missing ⚠️
editoast/src/views/train_schedule/mod.rs 0.00% 4 Missing ⚠️
editoast/src/models/train_schedule.rs 0.00% 3 Missing ⚠️
...toast/src/views/pathfinding/electrical_profiles.rs 66.66% 2 Missing ⚠️
...st/src/schema/rolling_stock/light_rolling_stock.rs 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6821      +/-   ##
============================================
+ Coverage     28.66%   28.69%   +0.03%     
- Complexity     2235     2238       +3     
============================================
  Files          1063     1066       +3     
  Lines        131643   131758     +115     
  Branches       2647     2665      +18     
============================================
+ Hits          37729    37809      +80     
- Misses        92393    92413      +20     
- Partials       1521     1536      +15     
Flag Coverage Δ
core 79.80% <ø> (+0.02%) ⬆️
editoast 74.87% <61.66%> (-0.06%) ⬇️
front 8.99% <100.00%> (+0.06%) ⬆️
gateway 2.49% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais requested a review from Wadjetz March 8, 2024 17:51
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. I made a small change request.

@hamz2a hamz2a force-pushed the hai/editoast-move-light-rolling-stock-to-model-v2 branch 4 times, most recently from b4a7775 to 67d3d4b Compare March 15, 2024 10:35
@hamz2a hamz2a force-pushed the hai/editoast-move-light-rolling-stock-to-model-v2 branch from 67d3d4b to 43a5aa0 Compare March 15, 2024 11:01
@hamz2a hamz2a added this pull request to the merge queue Mar 15, 2024
Merged via the queue into dev with commit d63f569 Mar 15, 2024
22 checks passed
@hamz2a hamz2a deleted the hai/editoast-move-light-rolling-stock-to-model-v2 branch March 15, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move LightRollingStockModel to Model V2
3 participants