Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add telemetry propagators between gateway and editoast #6822

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

woshilapin
Copy link
Contributor

@woshilapin woshilapin commented Mar 7, 2024

This will allow traces to flow through services like they should. Here is an example in Datadog

image

Closes #6347

@woshilapin woshilapin force-pushed the wsl/feat/datadog-opentelemetry branch from 3b9367c to 821fe41 Compare March 7, 2024 16:16
Copy link

codecov bot commented Mar 7, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 28.27%. Comparing base (ae6706b) to head (e1354a7).

❗ Current head e1354a7 differs from pull request most recent head 670b9a1. Consider uploading reports for the commit 670b9a1 to get more accurate results

Files Patch % Lines
editoast/src/client/telemetry_config.rs 0.00% 6 Missing ⚠️
gateway/src/config.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6822      +/-   ##
============================================
- Coverage     28.27%   28.27%   -0.01%     
  Complexity     2179     2179              
============================================
  Files          1053     1053              
  Lines        130813   130814       +1     
  Branches       2602     2602              
============================================
- Hits          36984    36983       -1     
- Misses        92316    92318       +2     
  Partials       1513     1513              
Flag Coverage Δ
core 79.44% <ø> (ø)
editoast 74.82% <0.00%> (-0.01%) ⬇️
front 8.74% <ø> (ø)
gateway 2.49% <0.00%> (-0.01%) ⬇️
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@woshilapin woshilapin force-pushed the wsl/feat/opentelemetry-gateway-to-editoast branch from 40467bc to e1354a7 Compare March 7, 2024 16:23
@woshilapin woshilapin requested review from Wadjetz and flomonster March 7, 2024 17:24
@woshilapin woshilapin marked this pull request as ready for review March 7, 2024 17:24
@woshilapin woshilapin requested review from a team as code owners March 7, 2024 17:24
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from wsl/feat/datadog-opentelemetry to dev March 7, 2024 17:33
@woshilapin woshilapin force-pushed the wsl/feat/opentelemetry-gateway-to-editoast branch from e1354a7 to 670b9a1 Compare March 7, 2024 17:36
@woshilapin woshilapin enabled auto-merge March 8, 2024 10:38
Copy link
Member

@ElysaSrc ElysaSrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@woshilapin woshilapin added this pull request to the merge queue Mar 8, 2024
Merged via the queue into dev with commit 4862416 Mar 8, 2024
16 checks passed
@woshilapin woshilapin deleted the wsl/feat/opentelemetry-gateway-to-editoast branch March 8, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connect Trace ID between Gateway/Editoast
3 participants