Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle not enough path items for pathfinding endpoint #6851

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

younesschrifi
Copy link
Contributor

No description provided.

@younesschrifi younesschrifi requested a review from a team as a code owner March 12, 2024 09:04
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 89.18919% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 28.46%. Comparing base (f2d9e03) to head (d4d1d32).

Files Patch % Lines
editoast/src/views/v2/path/pathfinding.rs 25.00% 3 Missing ⚠️
front/src/common/api/osrdEditoastApi.ts 96.96% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6851   +/-   ##
=========================================
  Coverage     28.45%   28.46%           
  Complexity     2179     2179           
=========================================
  Files          1055     1055           
  Lines        131182   131216   +34     
  Branches       2602     2602           
=========================================
+ Hits          37329    37349   +20     
- Misses        92340    92354   +14     
  Partials       1513     1513           
Flag Coverage Δ
core 79.44% <ø> (ø)
editoast 74.90% <25.00%> (-0.06%) ⬇️
front 8.92% <96.96%> (+0.03%) ⬆️
gateway 2.49% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster changed the title editoast: add NotEnoughPathItem Error for Pathfinding Handle not enough path items for pathfinding endpoint Mar 12, 2024
@younesschrifi younesschrifi enabled auto-merge March 12, 2024 09:06
@younesschrifi younesschrifi force-pushed the yci/add-error-type-pathfinding branch from 8ae0904 to c2a387a Compare March 12, 2024 09:19
@younesschrifi younesschrifi added this pull request to the merge queue Mar 12, 2024
@younesschrifi younesschrifi removed this pull request from the merge queue due to a manual request Mar 12, 2024
@younesschrifi younesschrifi enabled auto-merge March 12, 2024 09:35
@younesschrifi younesschrifi added this pull request to the merge queue Mar 12, 2024
Merged via the queue into dev with commit a24e487 Mar 12, 2024
22 checks passed
@younesschrifi younesschrifi deleted the yci/add-error-type-pathfinding branch March 12, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants