Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: make budget nullable in project and study #6861

Merged

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Mar 12, 2024

closes #6775

@hamz2a hamz2a requested a review from a team as a code owner March 12, 2024 16:24
Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 27.02703% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 28.66%. Comparing base (a24e487) to head (1fda5a1).
Report is 46 commits behind head on dev.

Files Patch % Lines
...rc/applications/operationalStudies/views/Study.tsx 0.00% 7 Missing ⚠️
...dules/project/components/AddOrEditProjectModal.tsx 0.00% 7 Missing ⚠️
...c/modules/study/components/AddOrEditStudyModal.tsx 0.00% 7 Missing ⚠️
.../applications/operationalStudies/views/Project.tsx 0.00% 3 Missing ⚠️
front/src/modules/study/components/StudyCard.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6861      +/-   ##
============================================
+ Coverage     28.46%   28.66%   +0.19%     
- Complexity     2179     2235      +56     
============================================
  Files          1055     1063       +8     
  Lines        131216   131639     +423     
  Branches       2602     2647      +45     
============================================
+ Hits          37352    37728     +376     
- Misses        92351    92390      +39     
- Partials       1513     1521       +8     
Flag Coverage Δ
core 79.78% <ø> (+0.34%) ⬆️
editoast 74.92% <100.00%> (+0.01%) ⬆️
front 8.92% <12.90%> (-0.01%) ⬇️
gateway 2.49% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hamz2a hamz2a force-pushed the hai/editoast-budget-should-be-nullable-in-project-and-study branch from 069ef53 to 67b6c00 Compare March 12, 2024 17:08
@hamz2a hamz2a requested a review from a team as a code owner March 12, 2024 17:08
@hamz2a hamz2a force-pushed the hai/editoast-budget-should-be-nullable-in-project-and-study branch from 67b6c00 to 9a536ec Compare March 14, 2024 09:12
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an error while building the frontend.

Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To fix your build issue, you need to modify in :

  • AddOrEditStudyModal l.408 : value={currentStudy.budget ? currentStudy.budget : ''}
  • AddOrEditProjectModal l.387 : value={currentProject.budget ? currentProject.budget : ''}

and fix the comment below and it should be ok :)

@hamz2a hamz2a force-pushed the hai/editoast-budget-should-be-nullable-in-project-and-study branch 4 times, most recently from a6be30c to daee528 Compare March 14, 2024 12:46
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm but don't forget to fix in another PR the null bug for a patch

@hamz2a hamz2a force-pushed the hai/editoast-budget-should-be-nullable-in-project-and-study branch from daee528 to 1fda5a1 Compare March 14, 2024 16:55
@hamz2a hamz2a requested a review from flomonster March 14, 2024 17:06
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamz2a hamz2a added this pull request to the merge queue Mar 18, 2024
Merged via the queue into dev with commit 110eb8b Mar 18, 2024
22 checks passed
@hamz2a hamz2a deleted the hai/editoast-budget-should-be-nullable-in-project-and-study branch March 18, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Budget should be nullable in project and study
3 participants