-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: make budget nullable in project and study #6861
editoast: make budget nullable in project and study #6861
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6861 +/- ##
============================================
+ Coverage 28.46% 28.66% +0.19%
- Complexity 2179 2235 +56
============================================
Files 1055 1063 +8
Lines 131216 131639 +423
Branches 2602 2647 +45
============================================
+ Hits 37352 37728 +376
- Misses 92351 92390 +39
- Partials 1513 1521 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
069ef53
to
67b6c00
Compare
67b6c00
to
9a536ec
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is an error while building the frontend.
editoast/migrations/2024-03-12-143107_make_budget_nullable/down.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To fix your build issue, you need to modify in :
- AddOrEditStudyModal l.408 :
value={currentStudy.budget ? currentStudy.budget : ''}
- AddOrEditProjectModal l.387 :
value={currentProject.budget ? currentProject.budget : ''}
and fix the comment below and it should be ok :)
a6be30c
to
daee528
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm but don't forget to fix in another PR the null
bug for a patch
daee528
to
1fda5a1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
closes #6775