-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix selected color, typos, and add warning in speed-effort curve editor #6881
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6881 +/- ##
============================================
- Coverage 28.99% 28.91% -0.08%
Complexity 2244 2244
============================================
Files 1070 1070
Lines 132613 132635 +22
Branches 2688 2688
============================================
- Hits 38448 38354 -94
- Misses 92610 92726 +116
Partials 1555 1555
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eb90791
to
cb38779
Compare
145f15a
to
4f0bc3c
Compare
f6ebdf7
to
58f53d4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice PR, thanks for all this fixes :)
front/src/modules/rollingStock/components/RollingStockEditor/CurveParamSelectors.tsx
Outdated
Show resolved
Hide resolved
front/src/styles/scss/applications/rollingStockEditor/_rollingStockForm.scss
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job, thank you for this PR. Tested on local.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, you can fix my last 2 comments, squash and merge 👍
front/src/modules/rollingStock/components/RollingStockEditor/CurveParamSelectors.tsx
Outdated
Show resolved
Hide resolved
373f219
to
c689653
Compare
c689653
to
bcce47d
Compare
closes #6843
closes #6859
closes #6912