Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix selected color, typos, and add warning in speed-effort curve editor #6881

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Mar 14, 2024

closes #6843
closes #6859
closes #6912

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 1.14943% with 86 lines in your changes are missing coverage. Please review.

Project coverage is 28.91%. Comparing base (bff6e6c) to head (bcce47d).

Files Patch % Lines
front/src/common/Selector/Selector.tsx 0.00% 71 Missing ⚠️
...ponents/RollingStockEditor/CurveParamSelectors.tsx 6.25% 15 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6881      +/-   ##
============================================
- Coverage     28.99%   28.91%   -0.08%     
  Complexity     2244     2244              
============================================
  Files          1070     1070              
  Lines        132613   132635      +22     
  Branches       2688     2688              
============================================
- Hits          38448    38354      -94     
- Misses        92610    92726     +116     
  Partials       1555     1555              
Flag Coverage Δ
core 79.79% <ø> (ø)
editoast 74.87% <ø> (+0.01%) ⬆️
front 9.07% <1.14%> (-0.11%) ⬇️
gateway 2.49% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/fix-speed-effort-curve-selection branch 2 times, most recently from eb90791 to cb38779 Compare March 14, 2024 18:16
@Akctarus Akctarus changed the title front: fix selected color and add warning on speed-effort curve editor front: fix selected color and add warning in speed-effort curve editor Mar 14, 2024
@Akctarus Akctarus marked this pull request as ready for review March 14, 2024 18:24
@Akctarus Akctarus requested a review from a team as a code owner March 14, 2024 18:24
@Akctarus Akctarus force-pushed the tmn/fix-speed-effort-curve-selection branch 2 times, most recently from 145f15a to 4f0bc3c Compare March 15, 2024 15:28
@Akctarus Akctarus changed the title front: fix selected color and add warning in speed-effort curve editor front: fix selected color, typos, and add warning in speed-effort curve editor Mar 15, 2024
@Akctarus Akctarus force-pushed the tmn/fix-speed-effort-curve-selection branch 3 times, most recently from f6ebdf7 to 58f53d4 Compare March 18, 2024 11:03
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR, thanks for all this fixes :)

Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, thank you for this PR. Tested on local.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you can fix my last 2 comments, squash and merge 👍

@Akctarus Akctarus force-pushed the tmn/fix-speed-effort-curve-selection branch from 373f219 to c689653 Compare March 20, 2024 14:42
@Akctarus Akctarus force-pushed the tmn/fix-speed-effort-curve-selection branch from c689653 to bcce47d Compare March 20, 2024 14:43
@Akctarus Akctarus enabled auto-merge March 20, 2024 14:44
@Akctarus Akctarus added this pull request to the merge queue Mar 20, 2024
Merged via the queue into dev with commit 5408127 Mar 20, 2024
22 checks passed
@Akctarus Akctarus deleted the tmn/fix-speed-effort-curve-selection branch March 20, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants