Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: recompute Allowance Length when position change #6882

Merged
merged 1 commit into from
Mar 14, 2024

Conversation

achrafmohye
Copy link
Contributor

Closes: #6815

@achrafmohye achrafmohye requested a review from a team as a code owner March 14, 2024 08:26
@achrafmohye achrafmohye requested review from Math-R and Akctarus March 14, 2024 08:26
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 29 lines in your changes are missing coverage. Please review.

Project coverage is 28.46%. Comparing base (fbc0817) to head (3c76b07).

Files Patch % Lines
...nageTrainSchedule/Allowances/AllowancesActions.tsx 0.00% 29 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6882   +/-   ##
=========================================
  Coverage     28.46%   28.46%           
  Complexity     2179     2179           
=========================================
  Files          1055     1055           
  Lines        131222   131229    +7     
  Branches       2602     2602           
=========================================
+ Hits          37355    37358    +3     
- Misses        92354    92358    +4     
  Partials       1513     1513           
Flag Coverage Δ
core 79.44% <ø> (ø)
editoast 74.92% <ø> (+0.01%) ⬆️
front 8.92% <0.00%> (-0.01%) ⬇️
gateway 2.49% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Math-R Math-R added this pull request to the merge queue Mar 14, 2024
Merged via the queue into dev with commit 8433802 Mar 14, 2024
22 checks passed
@Math-R Math-R deleted the ame/front-6815-length-of-recovery-allowance-interval branch March 14, 2024 15:47
Copy link
Contributor

@Akctarus Akctarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

length of recovery allowance interval isn't properly computed/displayed
3 participants