Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TS2: Add simulation results endpoints setups #6889

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

younesschrifi
Copy link
Contributor

No description provided.

@younesschrifi younesschrifi requested a review from a team as a code owner March 14, 2024 13:14
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 30.98592% with 98 lines in your changes are missing coverage. Please review.

Project coverage is 28.69%. Comparing base (75bf2e9) to head (d731606).
Report is 10 commits behind head on dev.

Files Patch % Lines
editoast/src/views/v2/train_schedule.rs 28.69% 82 Missing ⚠️
editoast/src/views/v2/timetable.rs 40.74% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6889      +/-   ##
============================================
+ Coverage     28.65%   28.69%   +0.04%     
- Complexity     2223     2238      +15     
============================================
  Files          1059     1066       +7     
  Lines        131610   131900     +290     
  Branches       2646     2665      +19     
============================================
+ Hits          37711    37854     +143     
- Misses        92378    92510     +132     
- Partials       1521     1536      +15     
Flag Coverage Δ
core 79.80% <ø> (-0.01%) ⬇️
editoast 74.62% <30.98%> (-0.31%) ⬇️
front 8.99% <ø> (+0.06%) ⬆️
gateway 2.49% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi force-pushed the yci/add-simulation-results-endpoints branch 4 times, most recently from 36fd272 to b19e7c8 Compare March 14, 2024 14:09
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@younesschrifi younesschrifi force-pushed the yci/add-simulation-results-endpoints branch 2 times, most recently from 40c7ad4 to 79dd5fb Compare March 15, 2024 11:55
@younesschrifi younesschrifi force-pushed the yci/add-simulation-results-endpoints branch from 79dd5fb to d731606 Compare March 15, 2024 13:21
@younesschrifi younesschrifi self-assigned this Mar 19, 2024
@younesschrifi younesschrifi changed the title Add simulation results endpoints setups editoast: Add simulation results endpoints setups Mar 20, 2024
@younesschrifi younesschrifi changed the title editoast: Add simulation results endpoints setups TS2: Add simulation results endpoints setups Mar 20, 2024
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@younesschrifi younesschrifi added this pull request to the merge queue Mar 20, 2024
Merged via the queue into dev with commit bff6e6c Mar 20, 2024
22 checks passed
@younesschrifi younesschrifi deleted the yci/add-simulation-results-endpoints branch March 20, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants