-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: fix train arrival_time when adding a margin #6899
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6899 +/- ##
============================================
+ Coverage 28.65% 28.68% +0.03%
- Complexity 2223 2238 +15
============================================
Files 1059 1066 +7
Lines 131612 131765 +153
Branches 2647 2665 +18
============================================
+ Hits 37708 37800 +92
- Misses 92383 92429 +46
- Partials 1521 1536 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice bug fix. Do you think it's possible to add test on this, on order to avoid future regression?
20c7773
to
01c4141
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix is fine to me. I just made a small suggestion
01c4141
to
80b224d
Compare
2e929d2
to
19d75e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ LGTM
Close #6695