Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: signaling: add BAPR/TVM transitions #6900

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Conversation

eckter
Copy link
Contributor

@eckter eckter commented Mar 14, 2024

Fix #6871

I added the new modules, moved a couple so that the XXX->YYY transition is placed in the XXX module (it was inconsistent), and sorted the .addSignalDriver lines

@eckter eckter requested a review from a team as a code owner March 14, 2024 14:38
@eckter eckter requested a review from multun March 14, 2024 14:38
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 72.41379% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 28.65%. Comparing base (650963b) to head (b40fe75).

Files Patch % Lines
...kotlin/fr/sncf/osrd/signaling/bapr/BAPRtoTVM300.kt 60.00% 2 Missing ⚠️
...kotlin/fr/sncf/osrd/signaling/bapr/BAPRtoTVM430.kt 60.00% 2 Missing ⚠️
...tlin/fr/sncf/osrd/signaling/tvm300/TVM300toBAPR.kt 60.00% 2 Missing ⚠️
...tlin/fr/sncf/osrd/signaling/tvm430/TVM430toBAPR.kt 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #6900   +/-   ##
=========================================
  Coverage     28.65%   28.65%           
- Complexity     2223     2235   +12     
=========================================
  Files          1059     1063    +4     
  Lines        131612   131636   +24     
  Branches       2647     2647           
=========================================
+ Hits          37708    37723   +15     
- Misses        92383    92392    +9     
  Partials       1521     1521           
Flag Coverage Δ
core 79.78% <72.41%> (-0.03%) ⬇️
editoast 74.90% <ø> (-0.01%) ⬇️
front 8.92% <ø> (ø)
gateway 2.49% <ø> (ø)
railjson_generator 87.26% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@multun multun added this pull request to the merge queue Mar 14, 2024
Merged via the queue into dev with commit 86a48f5 Mar 14, 2024
22 checks passed
@multun multun deleted the ech/fix-signal-transition branch March 14, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

core: we don't have a signal driver for BAPR -> TVM430 signals
2 participants