core: fix detection zone creation around crossing node #6906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For a given crossing linking tracks North to South and East to West: A train detected coming from North can only be on North or South track (until detected again). But the detection zone's role is to protect from conflicts, and there may be a conflicting train from East to West. So the detection zone of a node must comprise all track section endpoints tied to the node.
bougue-pe
force-pushed
the
peb/core/fix_crossing_detection_zone
branch
from
6b3d915 to
60d4ecb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6906 +/- ##
============================================
- Coverage 28.66% 28.65% -0.01%
- Complexity 2235 2238 +3
============================================
Files 1063 1063
Lines 131643 131651 +8
Branches 2647 2650 +3
============================================
Hits 37729 37729
- Misses 92393 92401 +8
Partials 1521 1521
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
multun
approved these changes
Mar 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a given crossing node, linking tracks North to South and East to West: A train detected coming from North can only be on North or South track (until detected again).
But the detection zone's role is to protect from conflicts, and there may be a conflicting train from East to West.
So the detection zone of a node must comprise all track section endpoints tied to the node.