front: tests: add tests for formatSignalingSystems function #6919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6919 +/- ##
============================================
+ Coverage 28.95% 28.99% +0.03%
Complexity 2244 2244
============================================
Files 1070 1070
Lines 132700 132711 +11
Branches 2696 2708 +12
============================================
+ Hits 38429 38481 +52
+ Misses 92707 92654 -53
- Partials 1564 1576 +12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
clarani
reviewed
Mar 18, 2024
There was a problem hiding this comment.
Nice tests, thanks, it's a good start ! It would be nice to modify the function formatSignalingSystems (maybe rename it formatSignalingSystems => formSignalingSystem) so it takes only 1 logical_signal and format it as it might be easier to test.
// test only formatSignalingSystem
export function formatSignalingSystems(
entity: SignalEntity
): SignalEntity['properties']['logical_signals'] {
if (!entity.properties.logical_signals) return [];
return entity.properties.logical_signals.map((logicalSignal) => formatSignalingSystem(logicalSignal))Here are the use cases I can see for now:
- handle a BAL signal without default_parameters (initialization)
- handle a BAL signal with default_parameters
- handle a BAL signal with conditional_parameters
- handle a BAL signal with default_parameters and conditional_parameters becoming a BAPR signal
- handle a BAPR signal becoming a BAL signal
- handle a modification on a BAPR signal (update of settings)
front/src/applications/editor/tools/pointEdition/__tests__/utils.spec.ts
Outdated
Show resolved
Hide resolved
Yohh
reviewed
Mar 20, 2024
front/src/applications/editor/tools/pointEdition/__tests__/utils.spec.ts
Outdated
Show resolved
Hide resolved
Uriel-Sautron
force-pushed
the
usn/test-unitaire-formating-signaling-systems
branch
2 times, most recently
from
9be6159 to
737f342
Compare
clarani
approved these changes
Mar 20, 2024
fix comments - rename function formatSignalingSystems to formatSignalingSystem - formatSignalingSystem now takes a parameter of type SignalingSystemForm
Uriel-Sautron
force-pushed
the
usn/test-unitaire-formating-signaling-systems
branch
from
737f342 to
968b7f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #6920