Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add route-based speed section support in core #6948

Merged
merged 2 commits into from
Apr 11, 2024

Conversation

leovalais
Copy link
Contributor

closes #6523

@leovalais leovalais force-pushed the lva/conditional-speed-sections-core branch 2 times, most recently from 0296c7a to 488f06f Compare March 20, 2024 13:18
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 90.42553% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 29.08%. Comparing base (6c7dcbf) to head (2d48c03).
Report is 32 commits behind head on dev.

Files Patch % Lines
.../src/main/kotlin/fr/sncf/osrd/utils/units/Speed.kt 0.00% 4 Missing ⚠️
...kotlin/fr/sncf/osrd/sim_infra/impl/RawInfraImpl.kt 57.14% 2 Missing and 1 partial ⚠️
.../fr/sncf/osrd/sim_infra/impl/PathPropertiesImpl.kt 85.71% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6948      +/-   ##
============================================
+ Coverage     28.71%   29.08%   +0.36%     
- Complexity     2244     2255      +11     
============================================
  Files          1066     1072       +6     
  Lines        131896   132867     +971     
  Branches       2672     2720      +48     
============================================
+ Hits          37874    38644     +770     
- Misses        92483    92646     +163     
- Partials       1539     1577      +38     
Flag Coverage Δ
core 79.85% <85.00%> (+0.06%) ⬆️
editoast 74.84% <ø> (-0.05%) ⬇️
front 9.29% <ø> (+0.30%) ⬆️
gateway 2.45% <ø> (-0.05%) ⬇️
railjson_generator 87.49% <100.00%> (+0.34%) ⬆️
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leovalais leovalais force-pushed the lva/conditional-speed-sections-core branch 3 times, most recently from 5ebe7d2 to b2488a7 Compare March 20, 2024 14:00
@leovalais leovalais marked this pull request as ready for review March 20, 2024 14:11
@leovalais leovalais requested review from a team as code owners March 20, 2024 14:11
@leovalais leovalais requested a review from eckter March 20, 2024 14:11
@leovalais leovalais changed the title WIP: Add route-based speed section support in core Add route-based speed section support in core Mar 20, 2024
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for tests

@leovalais leovalais force-pushed the lva/conditional-speed-sections-core branch 2 times, most recently from e204171 to 2d48c03 Compare March 27, 2024 14:24
@leovalais leovalais requested a review from shenriotpro March 27, 2024 14:41
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR. I approve the railjson_generator changes.

@leovalais leovalais force-pushed the lva/conditional-speed-sections-core branch from 2d48c03 to f0e9e28 Compare April 10, 2024 12:02
@leovalais leovalais requested review from a team as code owners April 10, 2024 12:02
Copy link
Contributor

@shenriotpro shenriotpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for tests/

@leovalais leovalais requested a review from eckter April 10, 2024 14:59
@leovalais leovalais force-pushed the lva/conditional-speed-sections-core branch from 709571e to 8110062 Compare April 11, 2024 10:06
Copy link
Contributor

@eckter eckter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some very minor comments, otherwise LGTM

@leovalais leovalais force-pushed the lva/conditional-speed-sections-core branch from 78443cf to dde28f6 Compare April 11, 2024 10:40
@flomonster flomonster self-requested a review April 11, 2024 10:47
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approved

@leovalais leovalais added this pull request to the merge queue Apr 11, 2024
Merged via the queue into dev with commit a42cad3 Apr 11, 2024
17 checks passed
@leovalais leovalais deleted the lva/conditional-speed-sections-core branch April 11, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt core to handle these new speed section
4 participants