-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add route-based speed section support in core #6948
Conversation
0296c7a
to
488f06f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6948 +/- ##
============================================
+ Coverage 28.71% 29.08% +0.36%
- Complexity 2244 2255 +11
============================================
Files 1066 1072 +6
Lines 131896 132867 +971
Branches 2672 2720 +48
============================================
+ Hits 37874 38644 +770
- Misses 92483 92646 +163
- Partials 1539 1577 +38
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5ebe7d2
to
b2488a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for tests
python/railjson_generator/railjson_generator/schema/infra/speed_section.py
Show resolved
Hide resolved
python/railjson_generator/railjson_generator/schema/infra/speed_section.py
Show resolved
Hide resolved
e204171
to
2d48c03
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
core/kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/api/PathProperties.kt
Outdated
Show resolved
Hide resolved
core/kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/impl/PathPropertiesImpl.kt
Outdated
Show resolved
Hide resolved
core/kt-osrd-sim-infra/src/main/kotlin/fr/sncf/osrd/sim_infra/impl/RawInfraImpl.kt
Outdated
Show resolved
Hide resolved
core/src/main/java/fr/sncf/osrd/infra/api/tracks/undirected/SpeedLimits.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR. I approve the railjson_generator
changes.
2d48c03
to
f0e9e28
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for tests/
709571e
to
8110062
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some very minor comments, otherwise LGTM
core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/EngineeringAllowanceManager.kt
Outdated
Show resolved
Hide resolved
core/src/main/kotlin/fr/sncf/osrd/stdcm/graph/STDCMPostProcessing.kt
Outdated
Show resolved
Hide resolved
78443cf
to
dde28f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approved
closes #6523