Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: transform loading gauge type to enum #6956

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Mar 20, 2024

closes #6852

@hamz2a hamz2a requested a review from a team as a code owner March 20, 2024 16:12
Copy link

codecov bot commented Mar 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.99%. Comparing base (110eb8b) to head (dbff39d).
Report is 26 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6956      +/-   ##
============================================
+ Coverage     28.71%   28.99%   +0.28%     
  Complexity     2244     2244              
============================================
  Files          1066     1070       +4     
  Lines        131892   132712     +820     
  Branches       2672     2708      +36     
============================================
+ Hits          37873    38486     +613     
- Misses        92480    92650     +170     
- Partials       1539     1576      +37     
Flag Coverage Δ
core 79.80% <ø> (+0.01%) ⬆️
editoast 74.88% <100.00%> (-0.01%) ⬇️
front 9.21% <ø> (+0.22%) ⬆️
gateway 2.49% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice PR !
Some changes left :)

@hamz2a hamz2a force-pushed the hai/editoast-transform-loading-gauge-to-enum branch from c808d1b to f0129ee Compare March 21, 2024 10:20
@hamz2a hamz2a force-pushed the hai/editoast-transform-loading-gauge-to-enum branch from f0129ee to dbff39d Compare March 21, 2024 10:41
@hamz2a hamz2a requested a review from younesschrifi March 21, 2024 12:38
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Didn't know about the strum_macros::FromRepr so I learned something 😄

@hamz2a hamz2a added this pull request to the merge queue Mar 21, 2024
Merged via the queue into dev with commit 6ce53d9 Mar 21, 2024
22 checks passed
@hamz2a hamz2a deleted the hai/editoast-transform-loading-gauge-to-enum branch March 21, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt loading gauge of rolling stock model into an enum field
3 participants