-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: transform loading gauge type to enum #6956
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #6956 +/- ##
============================================
+ Coverage 28.71% 28.99% +0.28%
Complexity 2244 2244
============================================
Files 1066 1070 +4
Lines 131892 132712 +820
Branches 2672 2708 +36
============================================
+ Hits 37873 38486 +613
- Misses 92480 92650 +170
- Partials 1539 1576 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice PR !
Some changes left :)
editoast/migrations/2024-03-18-141345_change_loading_gauge_to_smallint/up.sql
Outdated
Show resolved
Hide resolved
c808d1b
to
f0129ee
Compare
f0129ee
to
dbff39d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Didn't know about the strum_macros::FromRepr
so I learned something 😄
closes #6852