Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: search: ops: display CI but search in UIC #6962

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

nicolaswurtz
Copy link
Contributor

@nicolaswurtz nicolaswurtz commented Mar 21, 2024

The complete UIC code was displayed but we weren't able to search with complete UIC code.

This PR fixes this behaviour: only CI code is displayed, but we can search for complete UIC or CI.

@nicolaswurtz nicolaswurtz added kind:bug Something isn't working difficulty:good first issue Good for newcomers labels Mar 21, 2024
@nicolaswurtz nicolaswurtz requested a review from a team as a code owner March 21, 2024 13:19
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 28.99%. Comparing base (36d0e3c) to head (99d338e).

Files Patch % Lines
...rc/common/Map/Search/MapSearchOperationalPoint.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #6962      +/-   ##
============================================
- Coverage     28.99%   28.99%   -0.01%     
  Complexity     2244     2244              
============================================
  Files          1070     1070              
  Lines        132711   132711              
  Branches       2708     2708              
============================================
- Hits          38486    38476      -10     
- Misses        92649    92659      +10     
  Partials       1576     1576              
Flag Coverage Δ
core 79.80% <ø> (ø)
editoast 74.84% <ø> (-0.05%) ⬇️
front 9.21% <0.00%> (ø)
gateway 2.49% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nicolaswurtz nicolaswurtz enabled auto-merge March 21, 2024 15:23
@nicolaswurtz nicolaswurtz added this pull request to the merge queue Mar 21, 2024
@Math-R
Copy link
Contributor

Math-R commented Mar 21, 2024

lgtm

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 21, 2024
@nicolaswurtz nicolaswurtz added this pull request to the merge queue Mar 21, 2024
Merged via the queue into dev with commit 12a36f2 Mar 21, 2024
22 checks passed
@nicolaswurtz nicolaswurtz deleted the nwz/replace-uic-by-ci-in-ops-search branch March 21, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
difficulty:good first issue Good for newcomers kind:bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants