-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
front: fix last e2e test (stdcm test) & remove the enable tag in e2e tests #6969
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #6969 +/- ##
============================================
- Coverage 28.95% 28.95% -0.01%
Complexity 2244 2244
============================================
Files 1070 1070
Lines 132524 132528 +4
Branches 2713 2713
============================================
- Hits 38377 38373 -4
- Misses 92570 92578 +8
Partials 1577 1577
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice! thank you for this last refacto!
1 comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, thank you for your work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 💪
ac4d491
to
d20fec7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm :)
+ remove the enable tag in e2e tests
d20fec7
to
7b43be0
Compare
closes #5510