Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: harmonize rtk usages #7039

Merged
merged 1 commit into from
Apr 2, 2024
Merged

front: harmonize rtk usages #7039

merged 1 commit into from
Apr 2, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Mar 28, 2024

closes #6974

@clarani clarani requested a review from a team as a code owner March 28, 2024 09:25
Copy link

codecov bot commented Mar 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 78 lines in your changes are missing coverage. Please review.

Project coverage is 28.99%. Comparing base (ff6564a) to head (32ab5b8).

Files Patch % Lines
...rc/applications/operationalStudies/views/Study.tsx 0.00% 16 Missing ⚠️
.../applications/operationalStudies/views/Project.tsx 0.00% 14 Missing ⚠️
front/src/applications/operationalStudies/Home.tsx 0.00% 8 Missing ⚠️
...onents/RollingStockCard/RollingStockCardDetail.tsx 0.00% 7 Missing ⚠️
...s/InfraSelector/InfraSelectorEditionActionsBar.tsx 0.00% 5 Missing ⚠️
...s/RollingStockEditor/RollingStockEditorButtons.tsx 0.00% 3 Missing ⚠️
...c/modules/study/components/AddOrEditStudyModal.tsx 0.00% 3 Missing ⚠️
.../operationalStudies/components/Study/StateStep.tsx 0.00% 2 Missing ⚠️
...applications/operationalStudies/views/Scenario.tsx 0.00% 2 Missing ⚠️
...common/ReleaseInformations/ReleaseInformations.tsx 0.00% 2 Missing ⚠️
... and 15 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7039      +/-   ##
============================================
- Coverage     29.00%   28.99%   -0.02%     
  Complexity     2244     2244              
============================================
  Files          1070     1070              
  Lines        132590   132577      -13     
  Branches       2713     2713              
============================================
- Hits          38463    38442      -21     
- Misses        92550    92558       +8     
  Partials       1577     1577              
Flag Coverage Δ
core 79.81% <ø> (ø)
editoast 74.93% <ø> (-0.09%) ⬇️
front 9.29% <0.00%> (+<0.01%) ⬆️
gateway 2.45% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Tested

@Math-R Math-R added this pull request to the merge queue Apr 2, 2024
Merged via the queue into dev with commit 45abf88 Apr 2, 2024
22 checks passed
@Math-R Math-R deleted the cni-6974-harmonize-rtk branch April 2, 2024 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

front: harmonize the rtk endpoints
3 participants