Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: Refactor MapSearchOperationalPoint component and handle keyboa… #7041

Merged
merged 1 commit into from
Apr 5, 2024
Merged

front: Refactor MapSearchOperationalPoint component and handle keyboa… #7041

merged 1 commit into from
Apr 5, 2024

Conversation

achrafmohye
Copy link
Contributor

Closes #6926

@achrafmohye achrafmohye requested a review from a team as a code owner March 28, 2024 10:31
@codecov Codecov
Copy link

codecov bot commented Mar 28, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 47 lines in your changes are missing coverage. Please review.

Project coverage is 28.30%. Comparing base (bfa97b6) to head (6f63b1e).
Report is 73 commits behind head on dev.

Files Patch % Lines
...rc/common/Map/Search/MapSearchOperationalPoint.tsx 0.00% 47 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7041      +/-   ##
============================================
- Coverage     29.05%   28.30%   -0.76%     
- Complexity     2244     2250       +6     
============================================
  Files          1070     1090      +20     
  Lines        132789   136513    +3724     
  Branches       2713     2746      +33     
============================================
+ Hits          38580    38638      +58     
- Misses        92632    96277    +3645     
- Partials       1577     1598      +21
Flag Coverage Δ
core 80.07% <ø> (+0.26%) ⬆️
editoast 74.79% <ø> (-0.10%) ⬇️
front 8.95% <0.00%> (-0.35%) ⬇️
gateway 2.45% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achrafmohye achrafmohye force-pushed the ame/front/6926-navigate-with-up-down-keys-in-search-results branch from e6b28cb to 7e6fecc Compare March 28, 2024 11:20
@achrafmohye achrafmohye self-assigned this Mar 28, 2024
clarani
clarani approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice enhancement, thanks !

@achrafmohye achrafmohye force-pushed the ame/front/6926-navigate-with-up-down-keys-in-search-results branch from 7e6fecc to 6f63b1e Compare April 5, 2024 08:23
clarani
clarani approved these changes Apr 5, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thanks ! ✅

@clarani clarani added this pull request to the merge queue Apr 5, 2024
Merged via the queue into dev with commit f12d90d Apr 5, 2024
22 checks passed
@clarani clarani deleted the ame/front/6926-navigate-with-up-down-keys-in-search-results branch April 5, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clarani clarani clarani approved these changes

Assignees

@achrafmohye achrafmohye

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Navigate with up/down arrow in search results
2 participants
@achrafmohye @clarani