Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: add trainSchedule v1/v2 switch #7060

Merged
merged 3 commits into from
Apr 3, 2024
Merged

front: add trainSchedule v1/v2 switch #7060

merged 3 commits into from
Apr 3, 2024

Conversation

clarani
Copy link
Contributor

@clarani clarani commented Mar 29, 2024

closes #7016

@clarani clarani requested a review from a team as a code owner March 29, 2024 11:49
@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0.38373% with 3894 lines in your changes are missing coverage. Please review.

Project coverage is 28.26%. Comparing base (fc0cd2e) to head (7328117).

Files Patch % Lines
...ainschedule/components/TimetableV2/TimetableV2.tsx 0.00% 526 Missing and 1 partial ⚠️
...ImportTrainSchedule/ImportTrainScheduleModalV2.tsx 0.00% 446 Missing and 1 partial ⚠️
...plications/operationalStudies/views/ScenarioV1.tsx 0.00% 385 Missing and 1 partial ⚠️
...cations/operationalStudies/views/v2/ScenarioV2.tsx 0.00% 372 Missing and 1 partial ⚠️
...mportTrainSchedule/ImportTrainScheduleConfigV2.tsx 0.00% 347 Missing and 1 partial ⚠️
...le/components/TimetableV2/TimetableTrainCardV2.tsx 0.00% 345 Missing and 1 partial ⚠️
...perationalStudies/views/v2/SimulationResultsV2.tsx 0.00% 275 Missing and 1 partial ⚠️
...riction/components/PowerRestrictionsSelectorV2.tsx 0.00% 199 Missing and 1 partial ⚠️
...rationalStudies/views/v2/ManageTrainScheduleV2.tsx 0.00% 192 Missing and 1 partial ⚠️
...s/pathfinding/components/Itinerary/ItineraryV2.tsx 0.00% 149 Missing and 1 partial ⚠️
... and 17 more
Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7060      +/-   ##
============================================
- Coverage     28.99%   28.26%   -0.73%     
  Complexity     2250     2250              
============================================
  Files          1070     1085      +15     
  Lines        132704   136177    +3473     
  Branches       2728     2744      +16     
============================================
+ Hits          38473    38489      +16     
- Misses        92651    96092    +3441     
- Partials       1580     1596      +16
Flag Coverage Δ
core 80.09% <ø> (ø)
editoast 74.64% <ø> (+0.03%) ⬆️
front 8.97% <0.38%> (-0.33%) ⬇️
gateway 2.45% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

flomonster
flomonster approved these changes Mar 29, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it seems to work :)

Uriel-Sautron
Uriel-Sautron reviewed Mar 29, 2024
View reviewed changes
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR

Caracol3
Caracol3 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@Caracol3 Caracol3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clarani clarani force-pushed the cni-7016-add-v2-switch branch from 8fa69ca to d631aae Compare April 2, 2024 07:49
RomainValls
RomainValls approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@RomainValls RomainValls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

kmer2016
kmer2016 approved these changes Apr 2, 2024
View reviewed changes
Copy link
Contributor

@kmer2016 kmer2016 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@clarani clarani force-pushed the cni-7016-add-v2-switch branch from d631aae to 7328117 Compare April 3, 2024 10:21
Math-R
Math-R approved these changes Apr 3, 2024
View reviewed changes
Copy link
Contributor

@Math-R Math-R left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@clarani clarani added this pull request to the merge queue Apr 3, 2024
Merged via the queue into dev with commit d5573a1 Apr 3, 2024
22 checks passed
@clarani clarani deleted the cni-7016-add-v2-switch branch April 3, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster approved these changes

@kmer2016 kmer2016 kmer2016 approved these changes

@Math-R Math-R Math-R approved these changes

@Uriel-Sautron Uriel-Sautron Uriel-Sautron approved these changes

@RomainValls RomainValls RomainValls approved these changes

@Caracol3 Caracol3 Caracol3 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: add a switch v1/v2 and setup components
7 participants
@clarani @flomonster @kmer2016 @Math-R @Uriel-Sautron @RomainValls @Caracol3