Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: remove default value for runserver cli threads arg #7071

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

Castavo
Copy link
Contributor

@Castavo Castavo commented Apr 2, 2024

This allows to use the behavior of Takes to use the max available number of threads, if no threads is given.

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 28.94%. Comparing base (a6faf4c) to head (a1ca4fd).
Report is 3 commits behind head on dev.

Files Patch % Lines
...c/main/java/fr/sncf/osrd/cli/ApiServerCommand.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7071      +/-   ##
============================================
- Coverage     28.95%   28.94%   -0.02%     
  Complexity     2244     2244              
============================================
  Files          1070     1070              
  Lines        132543   132543              
  Branches       2713     2714       +1     
============================================
- Hits          38379    38361      -18     
- Misses        92587    92605      +18     
  Partials       1577     1577              
Flag Coverage Δ
core 79.81% <0.00%> (ø)
editoast 74.77% <ø> (-0.08%) ⬇️
front 9.29% <ø> (ø)
gateway 2.45% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Castavo Castavo marked this pull request as ready for review April 2, 2024 09:24
@Castavo Castavo requested a review from a team as a code owner April 2, 2024 09:24
@Castavo Castavo requested a review from Erashin April 2, 2024 09:24
@Castavo Castavo added this pull request to the merge queue Apr 2, 2024
Merged via the queue into dev with commit 5b77a89 Apr 2, 2024
22 checks passed
@Castavo Castavo deleted the bpt/core/runserver-threads branch April 2, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants