editoast: make 'Result' more flexible #7074
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When defining a new `Result`, it's sometimes annoying having a `Result` available and trying to use it as `Result<T, E>` but actually, there is only one generic argument. Replacing `type Result<T> = StdResult<T, InternalError>` by `type Result<T, E = InternalError> = StdResult<T, E>` keep the bonus of using a custom `Result` (always returning our `InternalError`) but leaving the possibility to opt-out easily by specifying the second generic argument.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #7074 +/- ##
============================================
- Coverage 29.00% 29.00% -0.01%
Complexity 2250 2250
============================================
Files 1070 1070
Lines 132717 132717
Branches 2728 2728
============================================
- Hits 38500 38492 -8
- Misses 92637 92645 +8
Partials 1580 1580
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
leovalais
approved these changes
Apr 3, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When defining a new
Result, it's sometimes annoying having aResultavailable and trying to use it asResult<T, E>but actually, there is only one generic argument.Replacing
type Result<T> = StdResult<T, InternalError>bytype Result<T, E = InternalError> = StdResult<T, E>keep the bonus of using a customResult(always returning ourInternalError) but leaving the possibility to opt-out easily by specifying the second generic argument.Note: this seems to alleviate the CI problem on #6791. If someone is willing to dig more why these two seemingly unrelated things seem to interact, please do and share, I'm curious.