Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: fix infra lock status #7078

Merged
merged 1 commit into from
Apr 5, 2024
Merged

front: fix infra lock status #7078

merged 1 commit into from
Apr 5, 2024

Conversation

Akctarus
Copy link
Contributor

@Akctarus Akctarus commented Apr 3, 2024

closes #6952

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 28.33%. Comparing base (7c2a993) to head (6c109fc).
Report is 1 commits behind head on dev.

Files Patch % Lines
front/src/applications/editor/Editor.tsx 0.00% 16 Missing ⚠️
...cations/editor/tools/rangeEdition/tool-factory.tsx 0.00% 2 Missing ⚠️
...c/applications/editor/tools/switchEdition/tool.tsx 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7078      +/-   ##
============================================
- Coverage     28.33%   28.33%   -0.01%     
  Complexity     2268     2268              
============================================
  Files          1091     1091              
  Lines        136687   136701      +14     
  Branches       2770     2770              
============================================
- Hits          38734    38729       -5     
- Misses        96350    96369      +19     
  Partials       1603     1603              
Flag Coverage Δ
core 79.43% <ø> (ø)
editoast 74.79% <ø> (-0.03%) ⬇️
front 8.95% <0.00%> (-0.01%) ⬇️
gateway 2.45% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Akctarus Akctarus force-pushed the tmn/fix-infra-lock-status branch from c902bd2 to 9a4e517 Compare April 3, 2024 09:49
@Akctarus Akctarus marked this pull request as ready for review April 3, 2024 09:50
@Akctarus Akctarus requested a review from a team as a code owner April 3, 2024 09:50
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good work thank you.
Just a comment.

@Akctarus Akctarus force-pushed the tmn/fix-infra-lock-status branch 2 times, most recently from 9af5c49 to 948c41a Compare April 3, 2024 12:07
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The save button is not disabled in the speed limit tab :/
image

@Akctarus Akctarus force-pushed the tmn/fix-infra-lock-status branch 2 times, most recently from facefa9 to dabb677 Compare April 5, 2024 12:04
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested ✅

@Akctarus Akctarus force-pushed the tmn/fix-infra-lock-status branch from dabb677 to 6c109fc Compare April 5, 2024 12:53
@Akctarus Akctarus added this pull request to the merge queue Apr 5, 2024
Merged via the queue into dev with commit 5a54b4c Apr 5, 2024
23 checks passed
@Akctarus Akctarus deleted the tmn/fix-infra-lock-status branch April 5, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When infra is locked, front displays that we can still click on save
3 participants