Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: run all editoast workspace tests #7088

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Apr 4, 2024

We only run editoast tests, but we will need to run editoast_schemas tests too

Fix the modelv2 macro tests that weren't executed. The geo attribute is unimplemented!

@Wadjetz Wadjetz self-assigned this Apr 4, 2024
@Wadjetz Wadjetz added area:editoast Work on Editoast Service area:ci Work on Continous Integration Pipeline Service labels Apr 4, 2024
@Wadjetz Wadjetz requested review from woshilapin and multun April 4, 2024 09:47
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.34%. Comparing base (1615f74) to head (9531cce).
Report is 2 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7088      +/-   ##
============================================
+ Coverage     28.26%   28.34%   +0.07%     
  Complexity     2250     2250              
============================================
  Files          1085     1086       +1     
  Lines        136178   136329     +151     
  Branches       2744     2744              
============================================
+ Hits          38495    38640     +145     
- Misses        96087    96093       +6     
  Partials       1596     1596              
Flag Coverage Δ
core 80.08% <ø> (ø)
editoast 74.79% <100.00%> (+0.13%) ⬆️
front 8.97% <ø> (ø)
gateway 2.45% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz changed the title ci: run all workspace tests ci: run all editoast workspace tests Apr 4, 2024
@Wadjetz Wadjetz force-pushed the ebe/ci-run-all-workspaces-tests branch from 1abe793 to 9531cce Compare April 4, 2024 11:58
@Wadjetz Wadjetz requested a review from leovalais April 4, 2024 12:02
@Wadjetz Wadjetz marked this pull request as ready for review April 4, 2024 12:37
@Wadjetz Wadjetz requested review from a team as code owners April 4, 2024 12:37
@Wadjetz Wadjetz added this pull request to the merge queue Apr 4, 2024
Merged via the queue into dev with commit a664a09 Apr 4, 2024
22 checks passed
@Wadjetz Wadjetz deleted the ebe/ci-run-all-workspaces-tests branch April 4, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Work on Continous Integration Pipeline Service area:editoast Work on Editoast Service
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants