Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: move schema/operation to editoast::infra_cache #7089

Merged

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Apr 4, 2024

closes #7086

@hamz2a hamz2a requested a review from a team as a code owner April 4, 2024 10:06
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.26%. Comparing base (085922f) to head (67b5e0c).

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7089      +/-   ##
============================================
- Coverage     28.26%   28.26%   -0.01%     
  Complexity     2250     2250              
============================================
  Files          1086     1086              
  Lines        136178   136177       -1     
  Branches       2744     2744              
============================================
- Hits          38492    38491       -1     
  Misses        96090    96090              
  Partials       1596     1596              
Flag Coverage Δ
core 80.08% <ø> (ø)
editoast 74.65% <100.00%> (-0.01%) ⬇️
front 8.97% <ø> (ø)
gateway 2.45% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hamz2a hamz2a added this pull request to the merge queue Apr 4, 2024
Merged via the queue into dev with commit a3bf5bd Apr 4, 2024
22 checks passed
@hamz2a hamz2a deleted the hai/editoast-move-schema-operation-to-editoast-infra-cache branch April 4, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editoast: move schema/operation to editoast::infra_cache
3 participants