core: stdcm: stop computing engineering allowances during exploration #7090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #7090 +/- ##
============================================
- Coverage 28.31% 28.28% -0.04%
+ Complexity 2250 2229 -21
============================================
Files 1090 1090
Lines 136477 136492 +15
Branches 2745 2737 -8
============================================
- Hits 38647 38608 -39
- Misses 96233 96290 +57
+ Partials 1597 1594 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
eckter
force-pushed
the
ech/remove-stdcm-binary-search
branch
2 times, most recently
from
ae53f73 to
83ce5fa
Compare
Erashin
reviewed
Apr 5, 2024
Erashin
approved these changes
Apr 5, 2024
i.e. if we use a resource from t=42 to t=84, the conflict time can't start before t=42, even if the resource has been scheduled for longer
eckter
force-pushed
the
ech/remove-stdcm-binary-search
branch
from
83ce5fa to
bad2105
Compare
bloussou
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6985
The main change is that we don't actually compute engineering allowance during the exploration anymore. But that highlights all the subtle bugs we have around, especially in the post-processing, so it also includes some bugfixes.