Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: move rolling_resistance to schemas #7100

Merged
merged 1 commit into from
Apr 4, 2024
Merged

editoast: move rolling_resistance to schemas #7100

merged 1 commit into from
Apr 4, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Apr 4, 2024

No description provided.

@Wadjetz Wadjetz added area:editoast Work on Editoast Service kind:refacto-task Task related to Refactorization Epic labels Apr 4, 2024
@Wadjetz Wadjetz self-assigned this Apr 4, 2024
@Wadjetz Wadjetz force-pushed the ebe/editoast-move-rolling-resistance-to-schemas branch from 7d23a3e to 1f45006 Compare April 4, 2024 14:37
@Wadjetz Wadjetz force-pushed the ebe/editoast-move-rolling-resistance-to-schemas branch from 1f45006 to dfc5964 Compare April 4, 2024 14:39
@codecov Codecov
Copy link

codecov bot commented Apr 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.34%. Comparing base (69250c3) to head (dfc5964).

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7100      +/-   ##
============================================
- Coverage     28.34%   28.34%   -0.01%     
  Complexity     2250     2250              
============================================
  Files          1087     1088       +1     
  Lines        136329   136329              
  Branches       2744     2744              
============================================
- Hits          38648    38640       -8     
- Misses        96085    96093       +8     
  Partials       1596     1596
Flag Coverage Δ
core 80.08% <ø> (ø)
editoast 74.79% <100.00%> (-0.04%) ⬇️
front 8.97% <ø> (ø)
gateway 2.45% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.07% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz requested review from woshilapin and hamz2a April 4, 2024 14:54
@Wadjetz Wadjetz marked this pull request as ready for review April 4, 2024 14:54
@Wadjetz Wadjetz requested a review from a team as a code owner April 4, 2024 14:54
woshilapin
woshilapin approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice and tiny.

@Wadjetz Wadjetz added this pull request to the merge queue Apr 4, 2024
Merged via the queue into dev with commit ed26cf2 Apr 4, 2024
22 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast-move-rolling-resistance-to-schemas branch April 4, 2024 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin approved these changes

@hamz2a hamz2a hamz2a approved these changes

Assignees

@Wadjetz Wadjetz

Labels
area:editoast Work on Editoast Service kind:refacto-task Task related to Refactorization Epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Wadjetz @woshilapin @hamz2a