Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: move loading gauge, rs common and rs livery to schemas #7115

Merged
merged 3 commits into from
Apr 8, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Apr 5, 2024

Part of #7067

  • move loading gauge type to schemas
  • move rolling stock common to schemas
  • move rolling stock livery to schemas

@Wadjetz Wadjetz added area:ci Work on Continous Integration Pipeline Service kind:refacto-task Task related to Refactorization Epic labels Apr 5, 2024
@Wadjetz Wadjetz self-assigned this Apr 5, 2024
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.34%. Comparing base (a1681e8) to head (ec0a24f).

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7115      +/-   ##
============================================
- Coverage     28.34%   28.34%   -0.01%     
  Complexity     2247     2247              
============================================
  Files          1095     1097       +2     
  Lines        137950   137950              
  Branches       2761     2761              
============================================
- Hits          39102    39099       -3     
- Misses        97248    97251       +3     
  Partials       1600     1600              
Flag Coverage Δ
core 78.97% <ø> (ø)
editoast 72.88% <100.00%> (-0.02%) ⬇️
front 8.97% <ø> (ø)
gateway 2.45% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz force-pushed the ebe/editoast-move-loading-gauge-type-to-schemas branch from 8ed70a1 to 404a64c Compare April 5, 2024 13:21
@Wadjetz Wadjetz requested review from woshilapin and hamz2a April 5, 2024 13:22
@Wadjetz Wadjetz force-pushed the ebe/editoast-move-loading-gauge-type-to-schemas branch from 404a64c to b2c9148 Compare April 5, 2024 13:26
@Wadjetz Wadjetz marked this pull request as ready for review April 5, 2024 13:27
@Wadjetz Wadjetz requested a review from a team as a code owner April 5, 2024 13:27
@Wadjetz Wadjetz force-pushed the ebe/editoast-move-loading-gauge-type-to-schemas branch from b2c9148 to eb6a492 Compare April 5, 2024 14:56
@Wadjetz Wadjetz requested a review from woshilapin April 5, 2024 14:56
@Wadjetz Wadjetz force-pushed the ebe/editoast-move-loading-gauge-type-to-schemas branch 2 times, most recently from 21f8d60 to ce8da8a Compare April 5, 2024 16:00
@Wadjetz Wadjetz force-pushed the ebe/editoast-move-loading-gauge-type-to-schemas branch from ce8da8a to 2ecd5f0 Compare April 8, 2024 08:35
@Wadjetz Wadjetz changed the title editoast: move loading gauge type to schemas editoast: move loading gauge and rs common to schemas Apr 8, 2024
@Wadjetz Wadjetz changed the title editoast: move loading gauge and rs common to schemas editoast: move loading gauge and rs common, rs livery to schemas Apr 8, 2024
@Wadjetz Wadjetz changed the title editoast: move loading gauge and rs common, rs livery to schemas editoast: move loading gauge, rs common and rs livery to schemas Apr 8, 2024
@Wadjetz Wadjetz added this pull request to the merge queue Apr 8, 2024
Merged via the queue into dev with commit d2fdf2d Apr 8, 2024
23 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast-move-loading-gauge-type-to-schemas branch April 8, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:ci Work on Continous Integration Pipeline Service kind:refacto-task Task related to Refactorization Epic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants