Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: invert BAL and TVM transition drivers #7125

Merged
merged 3 commits into from
Apr 9, 2024
Merged

core: invert BAL and TVM transition drivers #7125

merged 3 commits into from
Apr 9, 2024

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Apr 8, 2024

BAL-TVM300 actually means a signal with a TVM output, not a TVM input.

@Khoyo Khoyo requested a review from a team as a code owner April 8, 2024 08:11
@Khoyo Khoyo requested a review from multun April 8, 2024 08:11
@Khoyo Khoyo self-assigned this Apr 8, 2024
@Khoyo Khoyo added kind:bug Something isn't working severity:critical Critical severity bug labels Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes are missing coverage. Please review.

Project coverage is 27.97%. Comparing base (7dd26cf) to head (a613ded).
Report is 4 commits behind head on dev.

Files Patch % Lines
...otlin/fr/sncf/osrd/signaling/tvm300/TVM300toBAL.kt 0.00% 16 Missing ⚠️
...n/kotlin/fr/sncf/osrd/signaling/bal/BALtoTVM300.kt 0.00% 12 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7125      +/-   ##
============================================
- Coverage     28.34%   27.97%   -0.37%     
  Complexity     2247     2247              
============================================
  Files          1095     1075      -20     
  Lines        137950   137057     -893     
  Branches       2761     2761              
============================================
- Hits          39100    38341     -759     
+ Misses        97250    97116     -134     
  Partials       1600     1600              
Flag Coverage Δ
core 78.97% <0.00%> (ø)
editoast 72.85% <ø> (-0.04%) ⬇️
front 8.97% <ø> (ø)
gateway 2.45% <ø> (ø)
railjson_generator 87.15% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

BAL-TVM300 actually means a signal with a TVM output, not a TVM input.
@Khoyo Khoyo requested a review from a team as a code owner April 9, 2024 11:07
@Khoyo Khoyo added this pull request to the merge queue Apr 9, 2024
Merged via the queue into dev with commit 5c92528 Apr 9, 2024
17 checks passed
@Khoyo Khoyo deleted the yk/tvm300 branch April 9, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:bug Something isn't working severity:critical Critical severity bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants