Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: move light rolling stock to views #7159

Merged
merged 1 commit into from
Apr 10, 2024
Merged

editoast: move light rolling stock to views #7159

merged 1 commit into from
Apr 10, 2024

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Apr 10, 2024 •
edited
Loading

part of #7048

  • Move LightRollingStock and others struct to views
  • Move rolling stock model v1 tests and From<> implementation to rolling stock model v2
  • Cleanup after the finish of moving rolling stock

@Wadjetz Wadjetz added area:editoast Work on Editoast Service kind:refacto-task Task related to Refactorization Epic labels Apr 10, 2024
@Wadjetz Wadjetz self-assigned this Apr 10, 2024
@Wadjetz Wadjetz requested a review from woshilapin April 10, 2024 08:20
@Wadjetz Wadjetz force-pushed the ebe/editoast-move-light-rollings-stock-to-schemas branch from 2e6f248 to 0feed90 Compare April 10, 2024 08:47
@Wadjetz Wadjetz marked this pull request as ready for review April 10, 2024 09:03
@Wadjetz Wadjetz requested a review from a team as a code owner April 10, 2024 09:04
woshilapin
woshilapin reviewed Apr 10, 2024
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that I understand this PR. LightRollingStock is not part of the schema? It would have been nice to put a bit of context in the description of the PR.

@Wadjetz Wadjetz force-pushed the ebe/editoast-move-light-rollings-stock-to-schemas branch from 0feed90 to 5261084 Compare April 10, 2024 09:27
@Wadjetz Wadjetz requested review from woshilapin and leovalais April 10, 2024 09:27
@Wadjetz Wadjetz force-pushed the ebe/editoast-move-light-rollings-stock-to-schemas branch from 5261084 to f9d19af Compare April 10, 2024 10:31
@Wadjetz Wadjetz changed the title editoast: move light rolling stock to schemas editoast: move light rolling stock to views Apr 10, 2024
@Wadjetz Wadjetz force-pushed the ebe/editoast-move-light-rollings-stock-to-schemas branch from f9d19af to 75d3fc3 Compare April 10, 2024 12:31
@Wadjetz Wadjetz force-pushed the ebe/editoast-move-light-rollings-stock-to-schemas branch from 75d3fc3 to 269264f Compare April 10, 2024 12:31
woshilapin
woshilapin approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a bunch of moving around, but for the greater good (views, modelsv2 and schema). Thanks!

@Wadjetz Wadjetz added this pull request to the merge queue Apr 10, 2024
Merged via the queue into dev with commit 56cbb36 Apr 10, 2024
17 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast-move-light-rollings-stock-to-schemas branch April 10, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woshilapin woshilapin woshilapin approved these changes

@leovalais leovalais Awaiting requested review from leovalais

Assignees

@Wadjetz Wadjetz

Labels
area:editoast Work on Editoast Service kind:refacto-task Task related to Refactorization Epic
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Wadjetz @woshilapin