gateway: relax versions to minimal acceptable versions #7161
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent commit did relax all versions in
gateway
(see 748e2d4).However, it's probably too relaxed. For example,
actix_auth
now depends onopenidconnect:3
with the featurejwk-alg
, but this feature is only available startingopenidconnect:3.4
. So I believe relaxing is more than OK, but only if the lower bound is good enough for compiling which is not the case anymore.You can try this to see the effect (see documentation of this nightly feature).
Once you fix one, then another constraint comes up and another minimal bound need to be fixed. This PR should provide all the minimal versions in which
gateway
can be compiled, hopefully.For comparison, here the original commit, and here is the comparison the current PR would have made. It still relax a bunch of the constraints, but not as much.
Happy to hear opinions on that.