Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: relax versions to minimal acceptable versions #7161

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

woshilapin
Copy link
Contributor

A recent commit did relax all versions in gateway (see 748e2d4).

However, it's probably too relaxed. For example, actix_auth now depends on openidconnect:3 with the feature jwk-alg, but this feature is only available starting openidconnect:3.4. So I believe relaxing is more than OK, but only if the lower bound is good enough for compiling which is not the case anymore.

You can try this to see the effect (see documentation of this nightly feature).

cargo +nightly update -Zdirect-minimal-versions
cargo check

Once you fix one, then another constraint comes up and another minimal bound need to be fixed. This PR should provide all the minimal versions in which gateway can be compiled, hopefully.

For comparison, here the original commit, and here is the comparison the current PR would have made. It still relax a bunch of the constraints, but not as much.

Happy to hear opinions on that.

@woshilapin woshilapin requested a review from multun April 10, 2024 09:00
@woshilapin woshilapin requested a review from a team as a code owner April 10, 2024 09:00
@multun
Copy link
Contributor

multun commented Apr 10, 2024

@woshilapin Thanks, nice change :) For some reason the Cargo.lock you're submitting downgrades multiple packages, can you look into it? It should only upgrade stuff afaik

@woshilapin woshilapin force-pushed the wsl/chore/gateway-minimal-versions branch from 18e3201 to 076ccca Compare April 10, 2024 09:32
@woshilapin
Copy link
Contributor Author

woshilapin commented Apr 10, 2024

@woshilapin Thanks, nice change :) For some reason the Cargo.lock you're submitting downgrades multiple packages, can you look into it? It should only upgrade stuff afaik

Aouch, nice that you catch that. I submitted the Cargo.lock that I produced after running the cargo +nightly update -Zdirect-minimal-versions... so yes, it was basically all the minimal versions. Thanks, I fixed it (with a cargo update so it might also update some of them).

@woshilapin woshilapin enabled auto-merge April 10, 2024 12:39
@woshilapin woshilapin added this pull request to the merge queue Apr 10, 2024
Merged via the queue into dev with commit 948fbbc Apr 10, 2024
17 checks passed
@woshilapin woshilapin deleted the wsl/chore/gateway-minimal-versions branch April 10, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants