Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: move NeutralSection and ElectricalProfile to editoast_schemas #7220

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Apr 15, 2024

Part of #7048

@hamz2a hamz2a requested a review from a team as a code owner April 15, 2024 13:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.49%. Comparing base (5b0c515) to head (73c5096).
Report is 3 commits behind head on dev.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7220       +/-   ##
=============================================
+ Coverage     28.15%   87.49%   +59.33%     
=============================================
  Files          1119       31     -1088     
  Lines        139229     1535   -137694     
  Branches       2780        0     -2780     
=============================================
- Hits          39197     1343    -37854     
+ Misses        98424      192    -98232     
+ Partials       1608        0     -1608     
Flag Coverage Δ
core ?
editoast ?
front ?
gateway ?
railjson_generator 87.49% <ø> (ø)
tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, keep up the good work!

@hamz2a hamz2a added this pull request to the merge queue Apr 15, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 15, 2024
@hamz2a hamz2a added this pull request to the merge queue Apr 15, 2024
Merged via the queue into dev with commit 3154290 Apr 15, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-move-infra-elements-to-editoast-schemas branch April 15, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants