Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

front: adapt itinerary for TS2 #7227

Merged
merged 1 commit into from
May 6, 2024
Merged

front: adapt itinerary for TS2 #7227

merged 1 commit into from
May 6, 2024

Conversation

SharglutDev
Copy link
Contributor

close #7022

@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 10.71823% with 2424 lines in your changes are missing coverage. Please review.

Project coverage is 29.00%. Comparing base (6b648d8) to head (56bcd9b).
Report is 1 commits behind head on dev.

Files Patch % Lines
...thfinding/components/Pathfinding/TypeAndPathV2.tsx 0.00% 369 Missing and 1 partial ⚠️
...thfinding/components/Pathfinding/PathfindingV2.tsx 24.02% 334 Missing and 17 partials ⚠️
...ponents/Itinerary/DisplayItinerary/v2/OriginV2.tsx 0.00% 160 Missing and 1 partial ⚠️
...dule/ManageTrainScheduleMap/ItineraryMarkersV2.tsx 0.00% 159 Missing and 1 partial ⚠️
.../ManageTrainSchedule/helpers/checkCurrentConfig.ts 0.00% 155 Missing and 1 partial ⚠️
...ainSchedule/ManageTrainScheduleMap/RenderPopup.tsx 0.00% 141 Missing ⚠️
front/src/applications/operationalStudies/hooks.ts 0.00% 135 Missing and 1 partial ⚠️
...inding/components/Itinerary/ModalSuggestedVias.tsx 0.00% 125 Missing and 1 partial ⚠️
...s/ManageTrainSchedule/AddTrainScheduleV2Button.tsx 0.00% 113 Missing and 1 partial ⚠️
front/src/modules/pathfinding/utils.ts 24.19% 92 Missing and 2 partials ⚠️
... and 30 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7227      +/-   ##
============================================
- Coverage     29.14%   29.00%   -0.14%     
  Complexity     2016     2016              
============================================
  Files          1141     1157      +16     
  Lines        139977   142313    +2336     
  Branches       2769     2809      +40     
============================================
+ Hits          40793    41284     +491     
- Misses        97568    99375    +1807     
- Partials       1616     1654      +38
Flag Coverage Δ
core 76.29% <ø> (ø)
editoast 71.98% <ø> (-0.02%) ⬇️
front 9.65% <10.71%> (+0.28%) ⬆️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@SharglutDev SharglutDev force-pushed the pfn/front/trainschedulev2/adapt-itinerary branch 8 times, most recently from 7f8e87f to 425aaa9 Compare April 24, 2024 15:53
@SharglutDev SharglutDev force-pushed the pfn/front/trainschedulev2/adapt-itinerary branch 7 times, most recently from bc93b93 to 9b7bba0 Compare April 30, 2024 17:24
@SharglutDev SharglutDev marked this pull request as ready for review April 30, 2024 17:48
@SharglutDev SharglutDev requested a review from a team as a code owner April 30, 2024 17:48
clarani
clarani reviewed May 2, 2024
View reviewed changes
@SharglutDev SharglutDev force-pushed the pfn/front/trainschedulev2/adapt-itinerary branch from 6dfcc96 to 9783ccf Compare May 3, 2024 08:20
clarani
clarani reviewed May 3, 2024
View reviewed changes
clarani
clarani reviewed May 6, 2024
View reviewed changes
clarani
clarani reviewed May 6, 2024
View reviewed changes
clarani
clarani requested changes May 6, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there !

Uriel-Sautron
Uriel-Sautron reviewed May 6, 2024
View reviewed changes
Copy link
Contributor

@Uriel-Sautron Uriel-Sautron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this work, i'll continue the review

@SharglutDev SharglutDev force-pushed the pfn/front/trainschedulev2/adapt-itinerary branch from ff926af to 80049e6 Compare May 6, 2024 15:01
clarani
clarani approved these changes May 6, 2024
View reviewed changes
Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ tested

@SharglutDev SharglutDev force-pushed the pfn/front/trainschedulev2/adapt-itinerary branch from 80049e6 to 56bcd9b Compare May 6, 2024 16:08
@SharglutDev SharglutDev added this pull request to the merge queue May 6, 2024
Merged via the queue into dev with commit 83de943 May 6, 2024
17 checks passed
@SharglutDev SharglutDev deleted the pfn/front/trainschedulev2/adapt-itinerary branch May 6, 2024 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Uriel-Sautron Uriel-Sautron Uriel-Sautron left review comments

@clarani clarani clarani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

front: adapt Itinerary v2 behaviour
4 participants
@SharglutDev @codecov-commenter @clarani @Uriel-Sautron