Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: support an username whitelist for OIDC providers #7231

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

Khoyo
Copy link
Contributor

@Khoyo Khoyo commented Apr 16, 2024

Fixes #7229

@Khoyo Khoyo requested a review from a team as a code owner April 16, 2024 14:25
@Khoyo Khoyo force-pushed the yk/gateway-whitelist branch from 21405e0 to d17167b Compare April 16, 2024 14:26
@codecov-commenter
Copy link

codecov-commenter commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 10.87%. Comparing base (bde4844) to head (d17167b).
Report is 7 commits behind head on dev.

Files Patch % Lines
gateway/actix_auth/src/providers/oidc.rs 0.00% 9 Missing ⚠️
gateway/src/config_parser.rs 0.00% 2 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@              Coverage Diff              @@
##                dev    #7231       +/-   ##
=============================================
- Coverage     28.19%   10.87%   -17.32%     
=============================================
  Files          1128      601      -527     
  Lines        139439   100424    -39015     
  Branches       2804      930     -1874     
=============================================
- Hits          39309    10917    -28392     
+ Misses        98498    88582     -9916     
+ Partials       1632      925      -707     
Flag Coverage Δ
core ?
editoast ?
front 9.10% <ø> (ø)
gateway 2.43% <0.00%> (-0.02%) ⬇️
railjson_generator 87.49% <ø> (ø)
tests 83.98% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Khoyo Khoyo added this pull request to the merge queue Apr 18, 2024
Merged via the queue into dev with commit 3019050 Apr 18, 2024
17 checks passed
@Khoyo Khoyo deleted the yk/gateway-whitelist branch April 18, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add whitelist to the gateway
3 participants