Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core: implement path properties endpoint for time table v2 #7255

Merged
merged 3 commits into from
Apr 23, 2024
Merged

core: implement path properties endpoint for time table v2 #7255

merged 3 commits into from
Apr 23, 2024

Conversation

Erashin
Copy link
Contributor

@Erashin Erashin commented Apr 18, 2024 •
edited
Loading

Path properties v2 core endpoint + editoast call.

@Erashin Erashin force-pushed the alch/v2-pathproperties branch from ba3a8e5 to bbfe9b4 Compare April 18, 2024 07:45
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 62.23022% with 105 lines in your changes are missing coverage. Please review.

Project coverage is 28.30%. Comparing base (0bf04ff) to head (e9c82ae).
Report is 1 commits behind head on dev.

Files Patch % Lines
.../api_v2/path_properties/PathPropResultConverter.kt 50.00% 37 Missing and 3 partials ⚠️
editoast/src/views/v2/path/properties.rs 7.40% 25 Missing ⚠️
.../osrd/api/api_v2/path_properties/PathPropResult.kt 47.72% 23 Missing ⚠️
...tlin/fr/sncf/osrd/api/pathfinding/PathPropUtils.kt 65.00% 4 Missing and 3 partials ⚠️
.../infra/RJSOperationalPointIdentifierExtension.java 0.00% 4 Missing ⚠️
...srd/api/api_v2/path_properties/PathPropEndpoint.kt 76.92% 2 Missing and 1 partial ⚠️
editoast/src/core/v2/path_properties.rs 66.66% 2 Missing ⚠️
...srd/sim_infra/impl/new_impl/RawInfraImplFromRjs.kt 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7255      +/-   ##
============================================
- Coverage     28.35%   28.30%   -0.05%     
- Complexity     2006     2022      +16     
============================================
  Files          1139     1149      +10     
  Lines        139899   140065     +166     
  Branches       2707     2728      +21     
============================================
- Hits          39666    39648      -18     
- Misses        98615    98792     +177     
- Partials       1618     1625       +7
Flag Coverage Δ
core 78.05% <67.76%> (-0.16%) ⬇️
editoast 70.12% <20.58%> (-0.48%) ⬇️
front 9.14% <100.00%> (-0.01%) ⬇️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Erashin Erashin force-pushed the alch/v2-pathproperties branch from bbfe9b4 to 0588f8b Compare April 18, 2024 08:15
@Erashin Erashin linked an issue Apr 18, 2024 that may be closed by this pull request
TS2: Add core path properties endpoint #6786
Closed
1 task
@Erashin Erashin added the area:core Work on Core Service label Apr 18, 2024
@Erashin Erashin force-pushed the alch/v2-pathproperties branch 2 times, most recently from 5514f94 to 386c6e5 Compare April 19, 2024 06:54
@Erashin Erashin changed the base branch from dev to core/infra_load_refactor April 19, 2024 06:54
@Erashin Erashin force-pushed the alch/v2-pathproperties branch 2 times, most recently from b58febb to 5de0b88 Compare April 19, 2024 08:40
@multun multun force-pushed the core/infra_load_refactor branch 2 times, most recently from 89c91b6 to 5b5d931 Compare April 19, 2024 09:15
@Erashin Erashin force-pushed the alch/v2-pathproperties branch from 5de0b88 to a9dff92 Compare April 19, 2024 09:24
@multun multun force-pushed the core/infra_load_refactor branch from 5b5d931 to ebbeb01 Compare April 19, 2024 11:53
@Erashin Erashin force-pushed the alch/v2-pathproperties branch 3 times, most recently from 3258d12 to ed95da6 Compare April 19, 2024 13:22
@multun multun force-pushed the core/infra_load_refactor branch 2 times, most recently from f2d4583 to 8873c87 Compare April 19, 2024 13:36
Base automatically changed from core/infra_load_refactor to dev April 19, 2024 14:17
@Erashin Erashin force-pushed the alch/v2-pathproperties branch 4 times, most recently from 3243d49 to 5647530 Compare April 21, 2024 22:48
@Erashin Erashin marked this pull request as ready for review April 21, 2024 22:48
@Erashin Erashin requested review from a team as code owners April 21, 2024 22:48
@Erashin Erashin requested a review from eckter April 21, 2024 22:48
@Erashin Erashin force-pushed the alch/v2-pathproperties branch from 5647530 to bc61968 Compare April 22, 2024 01:34
@Erashin Erashin force-pushed the alch/v2-pathproperties branch from bc61968 to 56396eb Compare April 22, 2024 02:15
younesschrifi
younesschrifi approved these changes Apr 22, 2024
View reviewed changes
Copy link
Contributor

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Reviewed editoast part :)

@Erashin Erashin force-pushed the alch/v2-pathproperties branch 2 times, most recently from 4fa2a51 to 908af48 Compare April 23, 2024 07:27
@Erashin Erashin force-pushed the alch/v2-pathproperties branch 2 times, most recently from efc7fce to 8f8c8d7 Compare April 23, 2024 08:42
leovalais
leovalais approved these changes Apr 23, 2024
View reviewed changes
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Erashin Erashin force-pushed the alch/v2-pathproperties branch from 2a05171 to 0383aab Compare April 23, 2024 08:56
@flomonster flomonster requested review from flomonster and removed request for eckter and flomonster April 23, 2024 08:56
@flomonster flomonster force-pushed the alch/v2-pathproperties branch from 0383aab to e9c82ae Compare April 23, 2024 09:05
@Erashin Erashin enabled auto-merge April 23, 2024 09:05
@Erashin Erashin added this pull request to the merge queue Apr 23, 2024
Merged via the queue into dev with commit 453750c Apr 23, 2024
17 checks passed
@Erashin Erashin deleted the alch/v2-pathproperties branch April 23, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eckter eckter eckter left review comments

@flomonster flomonster flomonster left review comments

@multun multun multun approved these changes

@leovalais leovalais leovalais approved these changes

@younesschrifi younesschrifi younesschrifi approved these changes

Assignees
No one assigned
Labels
area:core Work on Core Service
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

TS2: Add core path properties endpoint
7 participants
@Erashin @codecov-commenter @eckter @multun @flomonster @leovalais @younesschrifi