Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: fix pathfinding v2 open api #7256

Merged
merged 1 commit into from
Apr 18, 2024

Conversation

younesschrifi
Copy link
Contributor

No description provided.

@younesschrifi younesschrifi requested a review from a team as a code owner April 18, 2024 07:56
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌

@younesschrifi younesschrifi force-pushed the yci/fix-openapi-path-properties branch from fb7bd65 to ebf7641 Compare April 18, 2024 08:11
@younesschrifi younesschrifi force-pushed the yci/fix-openapi-path-properties branch from ebf7641 to c089165 Compare April 18, 2024 08:13
@younesschrifi younesschrifi enabled auto-merge April 18, 2024 08:16
@younesschrifi younesschrifi added this pull request to the merge queue Apr 18, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 73.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 28.30%. Comparing base (6d81e1f) to head (c089165).

Files Patch % Lines
editoast/src/views/v2/path/pathfinding.rs 0.00% 3 Missing ⚠️
front/src/common/api/osrdEditoastApi.ts 90.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7256      +/-   ##
============================================
- Coverage     28.31%   28.30%   -0.01%     
  Complexity     2299     2299              
============================================
  Files          1142     1142              
  Lines        139792   139799       +7     
  Branches       2845     2845              
============================================
- Hits          39581    39570      -11     
- Misses        98561    98579      +18     
  Partials       1650     1650              
Flag Coverage Δ
core 78.55% <ø> (ø)
editoast 70.04% <40.00%> (-0.07%) ⬇️
front 9.12% <90.00%> (+<0.01%) ⬆️
gateway 2.45% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into dev with commit 8df770f Apr 18, 2024
17 checks passed
@younesschrifi younesschrifi deleted the yci/fix-openapi-path-properties branch April 18, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants