Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: clean up editoast::schema #7273

Merged
merged 5 commits into from
Apr 19, 2024
Merged

Conversation

hamz2a
Copy link
Contributor

@hamz2a hamz2a commented Apr 18, 2024

Part of #7048

@hamz2a hamz2a requested a review from a team as a code owner April 18, 2024 15:15
@codecov-commenter
Copy link

codecov-commenter commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 28.46%. Comparing base (8940bb7) to head (76b11ea).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #7273   +/-   ##
=========================================
  Coverage     28.46%   28.46%           
  Complexity     2299     2299           
=========================================
  Files          1155     1154    -1     
  Lines        140109   140044   -65     
  Branches       2845     2845           
=========================================
- Hits          39876    39870    -6     
+ Misses        98583    98524   -59     
  Partials       1650     1650           
Flag Coverage Δ
core 78.55% <ø> (ø)
editoast 70.52% <ø> (+0.14%) ⬆️
front 9.14% <ø> (ø)
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@woshilapin woshilapin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice clean up!

@hamz2a hamz2a added this pull request to the merge queue Apr 19, 2024
Merged via the queue into dev with commit b3228a3 Apr 19, 2024
17 checks passed
@hamz2a hamz2a deleted the hai/editoast-clean-up-editoast-schema branch April 19, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants