Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix power restriction field in simulation result #7298

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

younesschrifi
Copy link
Contributor

No description provided.

@younesschrifi younesschrifi requested a review from a team as a code owner April 23, 2024 09:58
@younesschrifi younesschrifi changed the title editoast: fix power restriction field in simulation result Fix power restriction field in simulation result Apr 23, 2024
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 90.90909% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 28.31%. Comparing base (bcbd74a) to head (4fad58d).
Report is 3 commits behind head on dev.

Files Patch % Lines
editoast/src/views/v2/train_schedule.rs 50.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7298      +/-   ##
============================================
- Coverage     28.36%   28.31%   -0.06%     
- Complexity     2006     2022      +16     
============================================
  Files          1139     1149      +10     
  Lines        139899   140074     +175     
  Branches       2707     2728      +21     
============================================
- Hits          39679    39657      -22     
- Misses        98602    98792     +190     
- Partials       1618     1625       +7     
Flag Coverage Δ
core 78.05% <ø> (-0.16%) ⬇️
editoast 70.12% <50.00%> (-0.53%) ⬇️
front 9.14% <100.00%> (+<0.01%) ⬆️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@younesschrifi younesschrifi added this pull request to the merge queue Apr 23, 2024
Merged via the queue into dev with commit 6152b45 Apr 23, 2024
17 checks passed
@younesschrifi younesschrifi deleted the yci/fix-power-restriction-in-simulation branch April 23, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants