Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

front: source extension for editor #7323

Merged
merged 1 commit into from
Apr 26, 2024
Merged

front: source extension for editor #7323

merged 1 commit into from
Apr 26, 2024

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Apr 25, 2024

See message in #384
Fix #7314

  • remove source edition if object has no source data
  • if object has source data, on form, source are readonly
  • add source data on entity sumup

* remove source edition if object has no source data
* if object has source data, on form, source are readonly
* add source data on entity sumup

See message in #384
Fix #7314
@sim51 sim51 requested a review from a team as a code owner April 25, 2024 18:48
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2024

Codecov Report

Attention: Patch coverage is 0% with 48 lines in your changes are missing coverage. Please review.

Project coverage is 28.92%. Comparing base (c2a5fa9) to head (1685da8).

Files Patch % Lines
.../trackEdition/components/TrackEditionLeftPanel.tsx 0.00% 33 Missing and 1 partial ⚠️
...src/applications/editor/components/EntitySumUp.tsx 0.00% 13 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7323      +/-   ##
============================================
- Coverage     28.94%   28.92%   -0.02%     
  Complexity     2004     2004              
============================================
  Files          1126     1126              
  Lines        138733   138777      +44     
  Branches       2684     2684              
============================================
- Hits          40152    40146       -6     
- Misses        96984    97034      +50     
  Partials       1597     1597              
Flag Coverage Δ
core 78.37% <ø> (ø)
editoast 72.03% <ø> (-0.03%) ⬇️
front 9.32% <0.00%> (-0.01%) ⬇️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@clarani clarani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✅ tested

@sim51 sim51 added this pull request to the merge queue Apr 26, 2024
Merged via the queue into dev with commit 1cbd1e4 Apr 26, 2024
17 checks passed
@sim51 sim51 deleted the bsi/issue-7314 branch April 26, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

editor: source extension should not be required to edit or create an object
3 participants