Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

editoast: split track section endpoint #7326

Merged
merged 1 commit into from
May 16, 2024
Merged

editoast: split track section endpoint #7326

merged 1 commit into from
May 16, 2024

Conversation

sim51
Copy link
Contributor

@sim51 sim51 commented Apr 26, 2024 •
edited by flomonster
Loading

close #7007

@sim51 sim51 changed the title editoast: WIP on split track section endpoint editoast: split track section endpoint (WIP) Apr 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.16248% with 202 lines in your changes are missing coverage. Please review.

Project coverage is 29.39%. Comparing base (31078d8) to head (81f1ead).

Files Patch % Lines
editoast/src/views/infra/edition.rs 68.94% 186 Missing ⚠️
editoast/src/infra_cache/operation/create.rs 0.00% 5 Missing ⚠️
.../infra_cache/object_cache/neutral_section_cache.rs 71.42% 4 Missing ⚠️
front/src/common/api/osrdEditoastApi.ts 82.60% 4 Missing ⚠️
editoast/src/infra_cache/mod.rs 89.65% 3 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev    #7326      +/-   ##
============================================
+ Coverage     29.19%   29.39%   +0.20%     
  Complexity     2011     2011              
============================================
  Files          1170     1171       +1     
  Lines        144579   145240     +661     
  Branches       2822     2822              
============================================
+ Hits          42204    42689     +485     
- Misses       100711   100887     +176     
  Partials       1664     1664
Flag Coverage Δ
core 75.25% <ø> (ø)
editoast 72.47% <69.72%> (+0.01%) ⬆️
front 9.82% <82.60%> (+0.01%) ⬆️
gateway 2.41% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster self-requested a review April 26, 2024 15:39
@sim51 sim51 force-pushed the bsi/split-tracksection-back branch 2 times, most recently from 379a8a1 to 8a7bd0b Compare April 26, 2024 16:28
@sim51 sim51 marked this pull request as ready for review April 26, 2024 16:28
@sim51 sim51 requested a review from a team as a code owner April 26, 2024 16:28
flomonster
flomonster requested changes May 3, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment •
edited by woshilapin
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add a bunch of tests.

@sim51 sim51 force-pushed the bsi/split-tracksection-back branch 4 times, most recently from 87f4d57 to a26d1ab Compare May 14, 2024 16:27
@sim51 sim51 requested a review from a team as a code owner May 14, 2024 16:27
@sim51 sim51 changed the title editoast: split track section endpoint (WIP) editoast: split track section endpoint May 14, 2024
@sim51 sim51 force-pushed the bsi/split-tracksection-back branch 2 times, most recently from 69c5554 to cbee28b Compare May 15, 2024 10:20
@flomonster flomonster self-requested a review May 15, 2024 12:59
@sim51 sim51 force-pushed the bsi/split-tracksection-back branch from cbee28b to 3b94ba8 Compare May 15, 2024 13:36
@flomonster flomonster force-pushed the bsi/split-tracksection-back branch 2 times, most recently from a5fdac0 to 7a9280e Compare May 15, 2024 15:38
flomonster
flomonster approved these changes May 15, 2024
View reviewed changes
Copy link
Contributor

@flomonster flomonster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (reviewed + tested)

@sim51 sim51 force-pushed the bsi/split-tracksection-back branch 3 times, most recently from 6d6d113 to 1ed94e0 Compare May 15, 2024 17:26
@sim51 sim51 enabled auto-merge May 15, 2024 19:18
SharglutDev
SharglutDev reviewed May 16, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR ! Just 2 comments for trads :)

@sim51 sim51 force-pushed the bsi/split-tracksection-back branch from 1ed94e0 to 2c1705f Compare May 16, 2024 07:32
SharglutDev
SharglutDev reviewed May 16, 2024
View reviewed changes
@sim51 sim51 force-pushed the bsi/split-tracksection-back branch from 2c1705f to 81f1ead Compare May 16, 2024 07:44
SharglutDev
SharglutDev approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@SharglutDev SharglutDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm !

@sim51 sim51 added this pull request to the merge queue May 16, 2024
Merged via the queue into dev with commit 21906b8 May 16, 2024
17 checks passed
@sim51 sim51 deleted the bsi/split-tracksection-back branch May 16, 2024 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flomonster flomonster flomonster approved these changes

@SharglutDev SharglutDev SharglutDev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

back: split track in infra editor
4 participants
@sim51 @codecov-commenter @flomonster @SharglutDev