-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
editoast: connection type alias #7336
Conversation
b7c9808
to
0f0b0c5
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## dev #7336 +/- ##
============================================
+ Coverage 29.09% 29.11% +0.01%
Complexity 2020 2020
============================================
Files 1137 1138 +1
Lines 139647 139726 +79
Branches 2757 2757
============================================
+ Hits 40635 40681 +46
- Misses 97403 97436 +33
Partials 1609 1609
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I second @woshilapin's comment, otherwise lgtm thanks!
0f0b0c5
to
233d4ac
Compare
e4e9bb7
to
379f463
Compare
379f463
to
55b62fa
Compare
part of #6980