Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

editoast: connection type alias #7336

Merged
merged 5 commits into from
Apr 30, 2024
Merged

Conversation

Wadjetz
Copy link
Member

@Wadjetz Wadjetz commented Apr 29, 2024

part of #6980

  • Add Connection type alias for AsyncPgConnection
  • Add ConnectionPool type alias for diesel Pool
  • Add ConnectionConfig type alias for AsyncDieselConnectionManager
  • Refactor diesel pool creation fonction

@Wadjetz Wadjetz added area:editoast Work on Editoast Service kind:refacto-task Task related to Refactorization Epic labels Apr 29, 2024
@Wadjetz Wadjetz self-assigned this Apr 29, 2024
@Wadjetz Wadjetz force-pushed the ebe/editoast-connection-type-alias branch from b7c9808 to 0f0b0c5 Compare April 29, 2024 15:26
@Wadjetz Wadjetz marked this pull request as ready for review April 29, 2024 15:32
@Wadjetz Wadjetz requested a review from a team as a code owner April 29, 2024 15:32
@Wadjetz Wadjetz marked this pull request as draft April 29, 2024 15:32
@codecov-commenter
Copy link

codecov-commenter commented Apr 29, 2024

Codecov Report

Attention: Patch coverage is 76.29428% with 87 lines in your changes are missing coverage. Please review.

Project coverage is 29.11%. Comparing base (f72ba7f) to head (55b62fa).

Files Patch % Lines
editoast/src/modelsv2/connection_pool.rs 0.00% 26 Missing ⚠️
editoast/src/views/train_schedule/mod.rs 7.14% 13 Missing ⚠️
editoast/src/models/timetable.rs 30.00% 7 Missing ⚠️
editoast/src/views/v2/path/pathfinding.rs 0.00% 6 Missing ⚠️
editoast/src/views/v2/train_schedule.rs 53.84% 6 Missing ⚠️
editoast/src/models/mod.rs 25.00% 3 Missing ⚠️
editoast/src/views/timetable/import.rs 0.00% 3 Missing ⚠️
editoast/src/generated_data/error/mod.rs 71.42% 2 Missing ⚠️
editoast/src/modelsv2/infra.rs 87.50% 2 Missing ⚠️
editoast/src/views/rolling_stocks/mod.rs 87.50% 2 Missing ⚠️
... and 16 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #7336      +/-   ##
============================================
+ Coverage     29.09%   29.11%   +0.01%     
  Complexity     2020     2020              
============================================
  Files          1137     1138       +1     
  Lines        139647   139726      +79     
  Branches       2757     2757              
============================================
+ Hits          40635    40681      +46     
- Misses        97403    97436      +33     
  Partials       1609     1609              
Flag Coverage Δ
core 76.76% <ø> (ø)
editoast 72.04% <76.29%> (-0.04%) ⬇️
front 9.34% <ø> (ø)
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Wadjetz Wadjetz marked this pull request as ready for review April 30, 2024 07:19
Copy link
Contributor

@hamz2a hamz2a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I second @woshilapin's comment, otherwise lgtm thanks!

@Wadjetz Wadjetz force-pushed the ebe/editoast-connection-type-alias branch from 0f0b0c5 to 233d4ac Compare April 30, 2024 13:31
@Wadjetz Wadjetz requested a review from woshilapin April 30, 2024 14:06
@Wadjetz Wadjetz force-pushed the ebe/editoast-connection-type-alias branch from e4e9bb7 to 379f463 Compare April 30, 2024 14:37
@Wadjetz Wadjetz force-pushed the ebe/editoast-connection-type-alias branch from 379f463 to 55b62fa Compare April 30, 2024 14:39
@Wadjetz Wadjetz requested a review from woshilapin April 30, 2024 14:39
@Wadjetz Wadjetz enabled auto-merge April 30, 2024 14:49
@Wadjetz Wadjetz added this pull request to the merge queue Apr 30, 2024
Merged via the queue into dev with commit e21379d Apr 30, 2024
17 checks passed
@Wadjetz Wadjetz deleted the ebe/editoast-connection-type-alias branch April 30, 2024 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:editoast Work on Editoast Service kind:refacto-task Task related to Refactorization Epic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants