Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change train schedule endpoint batch post #7337

Merged
merged 3 commits into from
May 2, 2024

Conversation

flomonster
Copy link
Contributor

@flomonster flomonster commented Apr 29, 2024

@flomonster flomonster requested a review from a team as a code owner April 29, 2024 15:28
@flomonster flomonster marked this pull request as draft April 29, 2024 16:12
Copy link
Contributor

@leovalais leovalais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (1st pass)

@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 42.73504% with 67 lines in your changes are missing coverage. Please review.

Project coverage is 29.11%. Comparing base (85349f4) to head (f0fd1e2).

Files Patch % Lines
...tTrainSchedule/ImportTrainScheduleTrainsListV2.tsx 0.00% 46 Missing ⚠️
...rationalStudies/views/v2/ImportTrainScheduleV2.tsx 0.00% 8 Missing ⚠️
...mportTrainSchedule/ImportTrainScheduleConfigV2.tsx 0.00% 7 Missing ⚠️
front/src/common/api/osrdEditoastApi.ts 81.81% 4 Missing ⚠️
editoast/src/views/v2/timetable.rs 96.87% 1 Missing ⚠️
...ortTrainSchedule/generateTrainSchedulesPayloads.ts 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff            @@
##                dev    #7337   +/-   ##
=========================================
  Coverage     29.10%   29.11%           
  Complexity     2016     2016           
=========================================
  Files          1141     1141           
  Lines        139880   139903   +23     
  Branches       2769     2769           
=========================================
+ Hits          40709    40729   +20     
- Misses        97555    97558    +3     
  Partials       1616     1616           
Flag Coverage Δ
core 76.32% <ø> (ø)
editoast 71.95% <96.96%> (+0.03%) ⬆️
front 9.35% <21.42%> (+<0.01%) ⬆️
gateway 2.43% <ø> (ø)
railjson_generator 87.49% <ø> (ø)
tests 83.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flomonster flomonster marked this pull request as ready for review April 30, 2024 13:10
@flomonster flomonster requested a review from a team as a code owner April 30, 2024 13:10
@RomainValls RomainValls force-pushed the fam/adapt-trainschedule-v2-endpoint branch from 6ec0569 to c8439f6 Compare April 30, 2024 14:02
Copy link
Contributor

@younesschrifi younesschrifi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@flomonster flomonster force-pushed the fam/adapt-trainschedule-v2-endpoint branch 2 times, most recently from 58a6d7a to aa4937f Compare May 2, 2024 12:12
@flomonster flomonster force-pushed the fam/adapt-trainschedule-v2-endpoint branch from aa4937f to 440105a Compare May 2, 2024 14:27
@RomainValls RomainValls force-pushed the fam/adapt-trainschedule-v2-endpoint branch 2 times, most recently from 0778e36 to 8e65dcd Compare May 2, 2024 14:34
@RomainValls RomainValls force-pushed the fam/adapt-trainschedule-v2-endpoint branch from 8e65dcd to f0fd1e2 Compare May 2, 2024 14:43
@flomonster flomonster enabled auto-merge May 2, 2024 14:56
@flomonster flomonster requested a review from SharglutDev May 2, 2024 14:57
@flomonster flomonster disabled auto-merge May 2, 2024 14:57
@flomonster flomonster enabled auto-merge May 2, 2024 14:57
@flomonster flomonster disabled auto-merge May 2, 2024 14:57
@flomonster flomonster merged commit 22ea984 into dev May 2, 2024
17 checks passed
@flomonster flomonster deleted the fam/adapt-trainschedule-v2-endpoint branch May 2, 2024 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants